Merged
Conversation
The completer must always be non-nil when starting a client (working jobs). The prior check for `willExecuteJobs` provides the required safety without this additional nil check.
Don't need a redundant closure here to wrap the callback function.
bgentry
force-pushed
the
bg-always-a-completer-if-running-jobs
branch
from
2677139 to
c2f7956
Compare
brandur
approved these changes
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The completer must always be non-nil when starting a client (working jobs). The prior check for
willExecuteJobsprovides the required safety without this additional nil check.