Fix more aggressive fetch / prepare v0.14.1#668
Merged
Conversation
In ce141fa / #664, the client was tuned in an attempt to make it more aggressive about fetching more jobs when it has just fetched a full batch of jobs. Unfortunately, a conditional was missed and it ended up fetching aggressively any time a single job was fetched. This adds the correct conditional so that the `fetchWhenSlotsAreAvailable` flag only gets set when (a) the previous fetch was full, or (b) when the previous fetch was skipped due to being already full of jobs.
bgentry
force-pushed
the
bg-fix-more-aggressive-fetch
branch
from
015881d to
ef992b8
Compare
bgentry
force-pushed
the
bg-fix-more-aggressive-fetch
branch
from
ef992b8 to
9d2935e
Compare
tigrato
pushed a commit
to gravitational/river
that referenced
this pull request
Dec 18, 2024
* make tidy * fix over-aggressive fetching In ce141fa / riverqueue#664, the client was tuned in an attempt to make it more aggressive about fetching more jobs when it has just fetched a full batch of jobs. Unfortunately, a conditional was missed and it ended up fetching aggressively any time a single job was fetched. This adds the correct conditional so that the `fetchWhenSlotsAreAvailable` flag only gets set when (a) the previous fetch was full, or (b) when the previous fetch was skipped due to being already full of jobs. * prepare v0.14.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ce141fa / #664, the client was tuned in an attempt to make it more
aggressive about fetching more jobs when it has just fetched a full
batch of jobs. Unfortunately, a conditional was missed and it ended up
fetching aggressively any time a single job was fetched.
This adds the correct conditional so that the
fetchWhenSlotsAreAvailableflag only gets set when (a) the previousfetch was full, or (b) when the previous fetch was skipped due to being
already full of jobs.