Consolidate pollForSettingChanges with other producer subroutines#855
Merged
Consolidate pollForSettingChanges with other producer subroutines#855
pollForSettingChanges with other producer subroutines#855Conversation
I made some changes to the producer in #848 to fix an intermittent test introduced by queue pause/unpause by moving a goroutine into the producer's main start goroutine and making sure to wait on it finishing before leaving the producer. I didn't notice at the time that there's already a place where some other producer subroutines are started, and we can clean things up somewhat by moving `pollForSettingChanges` down to where the other subroutines are booted and consolidating the wait group.
bgentry
approved these changes
Apr 27, 2025
Contributor
Author
|
Thx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made some changes to the producer in #848 to fix an intermittent test
introduced by queue pause/unpause by moving a goroutine into the
producer's main start goroutine and making sure to wait on it finishing
before leaving the producer.
I didn't notice at the time that there's already a place where some
other producer subroutines are started, and we can clean things up
somewhat by moving
pollForSettingChangesdown to where the othersubroutines are booted and consolidating the wait group.