Use normal test helpers in example tests with testutil.PanicTB#857
Merged
Use normal test helpers in example tests with testutil.PanicTB#857
testutil.PanicTB#857Conversation
Uses `testutil.PanicTB` introduced in #848 to switch to using standard `riversharedtest` helpers like `WaitOrTimeoutN` instead of the ones created for example tests specifically like `waitForNJobs`. Cuts down on the number of helpers required and lets us use example tests across packages without having to copy and paste the same `waitForNJobs` into each one.
bgentry
approved these changes
Apr 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
testutil.PanicTBintroduced in #848 to switch to using standardriversharedtesthelpers likeWaitOrTimeoutNinstead of the onescreated for example tests specifically like
waitForNJobs. Cuts down onthe number of helpers required and lets us use example tests across
packages without having to copy and paste the same
waitForNJobsintoeach one.