Add option to make metric duration unit configurable + testing#10
Merged
Add option to make metric duration unit configurable + testing#10
Conversation
Here, bring in a new option `MiddlewareConfig.DurationUnit` which can be used to change the default duration of duration-based metrics from seconds to milliseconds. There seems to be a reasonable number of people in both the seconds and milliseconds camps [1], so it seems okay to make this configurable. The first release also didn't bother testing metrics (since at the time, I couldn't find a testing package for metrics like existed for traces), so we also bring in metrics tests for the existing behavior along with the new `DurationUnit` option. Also fixes a small bug wherein attributes weren't being assigned as expected to a couple of the metrics. Fixes #9. [1] open-telemetry/opentelemetry-specification#2977
brandur
force-pushed
the
brandur-millisecond-durations
branch
from
50e9fd8 to
b3294b8
Compare
This was referenced Apr 3, 2025
Contributor
Author
|
Excellent, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, bring in a new option
MiddlewareConfig.DurationUnitwhich can beused to change the default duration of duration-based metrics from
seconds to milliseconds. There seems to be a reasonable number of people
in both the seconds and milliseconds camps [1], so it seems okay to make
this configurable.
The first release also didn't bother testing metrics (since at the time,
I couldn't find a testing package for metrics like existed for traces),
so we also bring in metrics tests for the existing behavior along with
the new
DurationUnitoption.Also fixes a small bug wherein attributes weren't being assigned as
expected to a couple of the metrics.
Fixes #9.
[1] open-telemetry/opentelemetry-specification#2977