Add EnableSemanticMetrics setting to emit "semantic" metrics#13
Merged
Add EnableSemanticMetrics setting to emit "semantic" metrics#13
EnableSemanticMetrics setting to emit "semantic" metrics#13Conversation
Here, address #7 to bring in a new option `EnableSemanticMetrics` that causes the middleware to emit metrics compliant with OpenTelemetry's "semantic conventions" [1]. These are a way to have all pub/sub systems emit metrics with the same name and differentiated by attribute. I've put this behind a configuration option because I'm not super convinced that this is going to be an important feature for most people, and under the assumption that metrics are cheap but not free, it probably makes sense to emit only as many as necessary. Fixes #7. [1] https://opentelemetry.io/docs/specs/semconv/messaging/messaging-metrics/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, address #7 to bring in a new option
EnableSemanticMetricsthatcauses the middleware to emit metrics compliant with OpenTelemetry's
"semantic conventions" [1]. These are a way to have all pub/sub systems
emit metrics with the same name and differentiated by attribute.
I've put this behind a configuration option because I'm not super
convinced that this is going to be an important feature for most people,
and under the assumption that metrics are cheap but not free, it
probably makes sense to emit only as many as necessary.
Fixes #7.
[1] https://opentelemetry.io/docs/specs/semconv/messaging/messaging-metrics/