Use test-only sqlc queries instead of driver queries in test cases#30
Merged
Use test-only sqlc queries instead of driver queries in test cases#30
Conversation
Introduce a `JobGetByID` in sqlc which we switch to using in tests instead of using the inelegant `job_get_by_kind_and_unique_properties()` from the driver. This also lets us remove `driver` as a test fixture, thus simplifying the whole testing set up and making it easier to understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a
JobGetByIDin sqlc which we switch to using in testsinstead of using the inelegant
job_get_by_kind_and_unique_properties()from the driver. This also lets us remove
driveras a test fixture,thus simplifying the whole testing set up and making it easier to
understand.