feat: add possibility to specify server host address#157
Merged
brandur merged 1 commit intoriverqueue:masterfrom Sep 16, 2024
Merged
feat: add possibility to specify server host address#157brandur merged 1 commit intoriverqueue:masterfrom
brandur merged 1 commit intoriverqueue:masterfrom
Conversation
Collaborator
|
Thanks! I'm going to follow this up with a small docs patch because I don't think it's obvious enough as written here that |
Collaborator
|
@bgentry FYI, all builds from third party contributors are still failing because of a 403 on the Docker jobs. |
brandur
added a commit
that referenced
this pull request
Sep 16, 2024
Follows up #157 with some small clean up to how env vars are handled, a doc string making it clear that `HOST` is not require and may be left empty, along with a CHANGELOG entry.
Collaborator
|
Another thing we should possibly consider is when it's appropriate to have env vars prefixed with |
brandur
added a commit
that referenced
this pull request
Sep 16, 2024
Follows up #157 with some small clean up to how env vars are handled, a doc string making it clear that `HOST` is not require and may be left empty, along with a CHANGELOG entry.
brandur
added a commit
that referenced
this pull request
Sep 21, 2024
I realized after merging #157 that it's probably not appropriate to use the env var `HOST` because it's so ubiquitous and easily conflated with a value intended for a different, non-River use. For example, `HOST` is set automatically on every computer running Mac OS, and likely other operating systems as well. Since we're prefixing variables with `RIVER_` for other purposes like `RIVER_LOG_LEVEL` in #183 anyway, change this to `RIVER_HOST`. I think we should probably prefix some of the other env vars that River UI uses as well (e.g. `DEV` should maybe be `RIVER_DEV`), but after starting to do that I gave up on it for now since there were a couple where the right thing to do (prefix versus not) wasn't totally clear.
bgentry
pushed a commit
that referenced
this pull request
Nov 26, 2024
I realized after merging #157 that it's probably not appropriate to use the env var `HOST` because it's so ubiquitous and easily conflated with a value intended for a different, non-River use. For example, `HOST` is set automatically on every computer running Mac OS, and likely other operating systems as well. Since we're prefixing variables with `RIVER_` for other purposes like `RIVER_LOG_LEVEL` in #183 anyway, change this to `RIVER_HOST`. I think we should probably prefix some of the other env vars that River UI uses as well (e.g. `DEV` should maybe be `RIVER_DEV`), but after starting to do that I gave up on it for now since there were a couple where the right thing to do (prefix versus not) wasn't totally clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is already possible to specify the server port with the
PORTenv variable. This PR adds the possibility to also specify the host variable to avoid listening to all IP addresses.This is a nice to have when the container is launched in host network.