Conversation
Collaborator
spatecon
approved these changes
May 6, 2025
Contributor
Author
Another aspect to highlight about this search input: it attempts to behave as a single input in most ways, such as being able to use left/right arrows to continuously move the cursor between filters. Ideally it should be easy to use only the keyboard or to avoid needing to switch between input modes repeatedly. |
brandur
approved these changes
May 8, 2025
Collaborator
brandur
left a comment
There was a problem hiding this comment.
Cool, thanks for taking a look.
bgentry
added a commit
that referenced
this pull request
May 8, 2025
Issue #347 details how #344 broke some key parts of the frontend due to missing fields in the job list payloads (errors, logs, and metadata were removed from the job payload for the list API). The root issue is that the TypeScript types were not adjusted to reflect the new split Job type, so several parts of the code made reference to things they could no longer access (and didn't actually need anyway). In particular this was true for deserializing job payloads where the same logic was applied to all job responses. To fix this, update the types to have a separate `JobMinimal` and `Job` type just as the API backend does. Update all code that uses them to ensure the correct one is utilized. It's only list view stuff that needs `JobMinimal` for now. Fixes #347.
bgentry
added a commit
that referenced
this pull request
May 8, 2025
Issue #347 details how #344 broke some key parts of the frontend due to missing fields in the job list payloads (errors, logs, and metadata were removed from the job payload for the list API). The root issue is that the TypeScript types were not adjusted to reflect the new split Job type, so several parts of the code made reference to things they could no longer access (and didn't actually need anyway). In particular this was true for deserializing job payloads where the same logic was applied to all job responses. To fix this, update the types to have a separate `JobMinimal` and `Job` type just as the API backend does. Update all code that uses them to ensure the correct one is utilized. It's only list view stuff that needs `JobMinimal` for now. Fixes #347.
bgentry
added a commit
that referenced
this pull request
May 9, 2025
Issue #347 details how #344 broke some key parts of the frontend due to missing fields in the job list payloads (errors, logs, and metadata were removed from the job payload for the list API). The root issue is that the TypeScript types were not adjusted to reflect the new split Job type, so several parts of the code made reference to things they could no longer access (and didn't actually need anyway). In particular this was true for deserializing job payloads where the same logic was applied to all job responses. To fix this, update the types to have a separate `JobMinimal` and `Job` type just as the API backend does. Update all code that uses them to ensure the correct one is utilized. It's only list view stuff that needs `JobMinimal` for now. Fixes #347.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This adds complex faceted search filters to the job list UI to filter by kind, ID, priority, or queue. The UI supports essentially all keyboard and mouse/touch input, including navigation between filter items.
Not every combination of search here will be efficient at the database level, but this isn't a typical runtime query—it's a debugging tool for operators. Some risk here should be acceptable, and can be mitigated by setting appropriate query timeouts on the pool given to the UI's River client.
autocomplete.mp4
Fixes #242.