(bugfix) Supports errors = undefined in apiAttemptErrorsToAttemptErrors#348
Closed
spatecon wants to merge 1 commit intoriverqueue:masterfrom
Closed
(bugfix) Supports errors = undefined in apiAttemptErrorsToAttemptErrors#348spatecon wants to merge 1 commit intoriverqueue:masterfrom
spatecon wants to merge 1 commit intoriverqueue:masterfrom
Conversation
KaymeKaydex
approved these changes
May 8, 2025
Contributor
|
Hey, thank you for catching this and for proposing a fix! Ultimately the issue is that I forgot to update the typescript types to reflect the backend changes, so the proper fix is a little more involved than this PR. I've made those changes in #349. Given this was an unreleased commit, meanwhile you should be able to just use the previous commit to use the new job list filters without the changes that caused this breakage. Fixes should be merged soon anyway though. Got a few more items to get in before an official UI release, should be in the next few days at most! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #347
I've decided not to decouple
apiJobToJobas we use it for bothgetJobandlistJobsfor now. So simple check for empty (non-present)errorsarray is enough.Works just fine.