Merged
Conversation
…n principal_with_name
…Object suffix should be used extern and should be dropped for static functions
…Object suffix should be used extern and should be dropped for static functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many changes to principals to make them more pythonic.
Principals are modified locally and changes are pushed to the kerberos database via "commit()".
getters and setters are properly defined to access the local copy (some members are read-only)
date-based objects are returned as datetime.datetime or datetime.timedelta objects and the setters for these accept the datetime objects in addition to string types previously used by get_date(). None can be used to clear values.
retvals are initialized and check against the typedef KADM_OK.
All unit tests pass.