each iteration returns internal exception + trace#17
Merged
rjancewicz merged 1 commit intomasterfrom Jul 22, 2014
Merged
Conversation
PyObject_CallFunctionObjArgs should raise an exception if NULL is returned, in the event that it is we capture the exception state and once we return control from the c iteration loop raise the correct exception (rather than the generic one used previously). This should allow for easier debugging from the python layer when an error occurs within the callback.
rjancewicz
added a commit
that referenced
this pull request
Jul 22, 2014
each iteration returns internal exception + trace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyObject_CallFunctionObjArgs should raise an exception if NULL is
returned, in the event that it is we capture the exception state and
once we return control from the c iteration loop raise the correct
exception (rather than the generic one used previously).
This should allow for easier debugging from the python layer when an
error occurs within the callback.
All Unit Tests Pass.