create_principal extension + don't leak memory when raising errors#21
Closed
denys-duchier wants to merge 2 commits intorjancewicz:masterfrom
Closed
create_principal extension + don't leak memory when raising errors#21denys-duchier wants to merge 2 commits intorjancewicz:masterfrom
denys-duchier wants to merge 2 commits intorjancewicz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I started using your code to script updates to our kerberos server and I find it very convenient. For create_principal, I needed to pass a db option to say where to store it in our LDAP database (I am using a "x" keyword argument for that purpose, like the -x option in the kadmin tool).
As I was looking over the code, it seemed to me that it would often leak memory when using PyKAdmin_RETURN_ERROR. So I tried to fix that too.