Skip to content

Use an IdentitySet when testing for elements added/removed from large persisted collections #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daniels220 wants to merge 1 commit into from
Closed

Use an IdentitySet when testing for elements added/removed from large persisted collections #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions ReStore/SSWDBOwnedCollectionSpec.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,21 @@ deleteQuery
yourself!

elementsIn: aCollection notIn: anotherCollection

^aCollection reject: [ :each | anotherCollection identityIncludes: each]!
| testAgainst |
"For small collections, the IdentitySet is actually slower, so just stick with the original collection in that common case."
testAgainst := anotherCollection size < 10
ifTrue: [anotherCollection]
ifFalse: [anotherCollection asIdentitySet].
^aCollection reject: [:each | testAgainst identityIncludes: each].!

hasCollection: updatedCollection anyAdditionsOrRemovalsFrom: originalCollection

^updatedCollection size ~= originalCollection size or: [updatedCollection anySatisfy: [ :each | (originalCollection identityIncludes: each) not]]!
| testAgainst |
updatedCollection size = originalCollection size ifFalse: [^true].
"For small collections, the IdentitySet is actually slower, so just stick with the original collection in that common case."
testAgainst := originalCollection size < 10
ifTrue: [originalCollection]
ifFalse: [originalCollection asIdentitySet].
^updatedCollection anySatisfy: [:each | (testAgainst identityIncludes: each) not].!

orderingSpecs

Expand Down