Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I ran into an issue when trying to extract images, specifically I got "bad URI(is not URI?)".
The first link that was causing problems was
http://www.nigerianwatch.com/news/4844-efcc-asks-interpol-to-arrest-oil-magnate-who-fled-to-switzerland-with-politicians-cash-
precisely with the image "/images/stories/mikel fist clenched ii.png" (notice the white spaces). In a first stage I fixed this using URI.encode(image_path) and I made a rspec test.
But the problem came again in the following link
http://www.autoscout24.ch/de/d/audi-a4-kombi-2014-neu?nav=13&slot=474&vehid=2198816
with the image path "http://ad.dc2.adtech.de/adserv/3.0/780/4453480/0/194/ADTECH;loc=300;kvgroup=67;kvmake=audi;kvleasingcalc=33;key=67+audi+16+M+condition_47;grp=[group]"
So finally, I came with the solution to use the gem https://github.com/sporkmonger/addressable that solved both problems with these urls.
PS: This is my first pull-request