Skip to content

Add ability to specifiy cert_path and key_path#1

Open
skrivy wants to merge 3 commits intorlenglet:masterfrom
skrivy:master
Open

Add ability to specifiy cert_path and key_path#1
skrivy wants to merge 3 commits intorlenglet:masterfrom
skrivy:master

Conversation

@skrivy
Copy link
Copy Markdown

@skrivy skrivy commented Apr 6, 2017

Added ability to specify cert_path and key_path.

@nambrosch
Copy link
Copy Markdown

@rlenglet could you review please? i would like to use this with centos and this is one possible solution.

{
"operatingsystem": "Ubuntu"
}
],
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary, right?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependencies key is indeed required.. see https://puppet.com/docs/puppet/7.1/modules_metadata.html

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say so, otherwise I wouldn't put it there.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please note this is 3 years old merge request, which I am not able to support anymore as I don't remember this kind of details.

@nambrosch
Copy link
Copy Markdown

@rlenglet Checked back a year later to check on this PR which is still open, which it is :) I created a similar change last year for my own use, let me know if you'd prefer this solution and I'll create a PR -

https://github.com/nambrosch/puppet-openssl/blob/master/manifests/self_signed_certificate.pp#L97-L102

@rlenglet
Copy link
Copy Markdown
Owner

@nambrosch The name of the parameters doesn't matter much. But please address my comment from 15 months ago. 😀

@nambrosch
Copy link
Copy Markdown

@nambrosch The name of the parameters doesn't matter much. But please address my comment from 15 months ago. 😀

The PR from 2017 belongs to @skrivy so was hoping they would take responsibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants