Improve UI of preview Rlottie based on Vue.js#9
Improve UI of preview Rlottie based on Vue.js#9msnodeve wants to merge 2 commits intorlottie:masterfrom
Conversation
Summary
|
|
We commited final release version 1.0 |
feat: Improve UI/UX, additional features and refactoring
|
| <div class="uploadBTN py-3" style="align-center"> | ||
| <v-row | ||
| align="center" | ||
| justify="center"> |
There was a problem hiding this comment.
Please check coding style. And please follow it.
It seems that other places are using following coding style.
<v-row
align="center"
justify="center"
>
| > | ||
| <v-icon | ||
| color="#ffffff" | ||
| > |
There was a problem hiding this comment.
This is not a multiple lines. This could be a line.
| </div> | ||
| <div class="text-center mt-4"> | ||
| <v-row | ||
| class="px-5"> |
There was a problem hiding this comment.
This is not a multiple lines. This could be a line.
| <span> | ||
| <v-card class="m-0" max-width="400"> | ||
| <v-img class="white--text align-end" height="200px" | ||
| src="./assets/ChangeTR.png"> |
There was a problem hiding this comment.
Please keep your coding style.
| }); | ||
| }, | ||
| beforeDestroy() { | ||
| // window.removeEventListener("resize"); |
There was a problem hiding this comment.
Please remove unnecessary line.
There was a problem hiding this comment.
Thank you. but you are currently checking the oldest commit history. Please check it as new.
There was a problem hiding this comment.
Should we make new pull request for checking only most recent commit?
| <v-footer absolute color="#292c31" class="font-weight-medium" style="min-width:745px;" ref="footer"> | ||
| <div | ||
| class="content-width-100 px-16" | ||
| > |
There was a problem hiding this comment.
From line 3 to line 5 could be one line.
Please refer to the case using multiple lines on https://www.w3schools.com/html/html5_syntax.asp
Or you could make a rule of coding style, and keep it.
| <script> | ||
| module.exports = { | ||
| name: "loading-bar", | ||
| // props: ["user"], |
There was a problem hiding this comment.
You can remove this line
kimcinoo
left a comment
kimcinoo
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
I have some small things.
|
|
||
| - Setup the emscripten sdk environment | ||
| Follow DoDown and Install steps https://emscripten.org/docs/getting_started/downloads.html | ||
| Follow DoDown and Install steps https://emscripten.org/docs/getting_started/downloads.html |
| @@ -1,13 +1,11 @@ | |||
| # [Prettie](https://msnodeve.github.io/rlottie.github.io/) | |||
| # [Prettie](https://msnodeve.github.io/rlottie.github.io/) | |||
There was a problem hiding this comment.
Is this intended? This line introduce personal github.io page of msnodeve
| } | ||
| // const { keypath } = this.$store.getters; | ||
| // this.$store.commit('setKeypath', ' '); | ||
| // this.$store.commit('setKeypath', keypath); |
There was a problem hiding this comment.
Remove above 3 lines if those are not necessary.
| // Shortcut key function binding | ||
| document.addEventListener('keydown', function (e) { | ||
| if (e.ctrlKey && e.which == 76) { | ||
| // Hide and show layer list : Ctrl + L |
There was a problem hiding this comment.
Is this working for you?
It seems that there is not a key icon as the .Gif/manual_7.gif shows, and it is not able to close right bar using "Ctrl + L"
Does the "Hide and show layer list" mean "Hide and show layer list panel (whole right bar, as.Gif/manual_7.gif shows) "?
msnodeve
force-pushed
the
master
branch
3 times, most recently
from
c3ab2e6 to
1da366d
Compare
* Change properties * Task Management(undo, redo) * Control frame speed * Show keypath list in rlottie.json * Add / Remove Background image * Possible control canvas size and position with a mouse
|
Your reviews have resolved and combine multiple commits into one commit. |
|
I checked same #17 |
4 participants
Improve UI of preview Rlottie based on Vue.js
1.Footer
2.Right bar
3.Left bar
Stroke tabStroke tabColorOpacityThicknessCanvas size4.Center
5.Upper bar