Skip to content

Use babel config instead of metro to resolve lib in example app#2033

Merged
mfazekas merged 1 commit intomainfrom
mfazekas/example-babel-config
Jul 7, 2022
Merged

Use babel config instead of metro to resolve lib in example app#2033
mfazekas merged 1 commit intomainfrom
mfazekas/example-babel-config

Conversation

@mfazekas
Copy link
Contributor

@mfazekas mfazekas commented Jul 6, 2022

Use the same setup as react-native-reanimated and it's example. Advantages:

  • no need to start a ts watch
  • could enable web support (see: WIP: Web support #861)
  • similar setup with react-native-reanimated means we can copy their setup changes to solve future issues
  • disadvantage - not sure what's going on exactly, with inlineRequires/assetRegistryPath

Reverts #892, I could work around the asset issue with: assetRegistryPath. Then I had failure with Error: Requiring unknown module "undefined", this was worked around by inlineRequires/blockList:react-navigation-stack/...

@mfazekas mfazekas merged commit 44a508c into main Jul 7, 2022
@mfazekas mfazekas deleted the mfazekas/example-babel-config branch July 7, 2022 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant