Skip to content

Conversation

@rustatian
Copy link
Member

@rustatian rustatian commented Nov 6, 2025

Reason for This PR

  • temporal api v1.57
  • update temporal message structure

Description of Changes

[Author TODO: add description of changes.]

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

Release Notes

  • New Features

    • Added workflow worker process ID information to message metadata for enhanced workflow tracking.
  • Chores

    • Updated Go runtime environment and core dependencies to latest stable versions for improved compatibility and security.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian self-assigned this Nov 6, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 6, 2025

Walkthrough

The pull request updates the Go toolchain to version 1.24.2, bumps multiple dependencies including Temporal API, gRPC, and protobuf to newer versions, adds a new wwpid field to the temporal protocol buffer Message definition, and updates the third_party/api submodule reference.

Changes

Cohort / File(s) Change Summary
Go Toolchain and Dependencies
go.mod
Updated Go toolchain from 1.24 to 1.24.0, set toolchain to go1.24.2; retracted v4.13.0 (cmder API); bumped temporal API (v1.52.0 → v1.57.0), gRPC (v1.74.2 → v1.76.0), protobuf (v1.36.7 → v1.36.10), and genproto versions; updated indirect dependencies including golang.org/x/net, sys, and text.
Protocol Buffer Schema Enhancement
proto/temporal/v1/temporal.proto
Added new wwpid field (uint64, field number 14) to Message definition with comment "workflow worker pid".
Submodule Update
third_party/api
Updated submodule pointer from commit d96bd55e87799e9f6a33a1c40a56cfa932566bdf to 060dbc3216ca0032c1b1f4f82a7b7c37a035448c.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • go.mod: Verify dependency version bumps are compatible and intentional, especially temporal API and gRPC updates which may have API changes.
  • proto/temporal/v1/temporal.proto: Confirm field numbering (14) doesn't conflict with existing or reserved fields; verify the field name and comment align with intended functionality.
  • third_party/api submodule: Verify the new commit reference is the intended update and contains compatible changes.

Possibly related PRs

Suggested labels

C-enhancement

Suggested reviewers

  • wolfy-j

Poem

🐰 The toolchain hops to 1.24.2,
Dependencies dance in harmony,
A new wwpid field takes its place,
Protocol buffers embrace this grace! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ❓ Inconclusive The description provides reasoning (temporal api v1.57, update message structure) but leaves the 'Description of Changes' section incomplete with a TODO placeholder. Replace the TODO placeholder in 'Description of Changes' with specific details about the changes made to proto files, dependency versions, and the new wwpid field.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: regenerate proto' is directly related to the primary changes: proto file regeneration and dependency updates.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/temporal-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e422ab8 and 8942e03.

⛔ Files ignored due to path filters (14)
  • build/temporal/api/common/v1/message.pb.go is excluded by !**/*.pb.go
  • build/temporal/api/deployment/v1/message.pb.go is excluded by !**/*.pb.go
  • build/temporal/api/enums/v1/task_queue.pb.go is excluded by !**/*.pb.go
  • build/temporal/api/history/v1/message.pb.go is excluded by !**/*.pb.go
  • build/temporal/api/namespace/v1/message.pb.go is excluded by !**/*.pb.go
  • build/temporal/api/nexus/v1/message.pb.go is excluded by !**/*.pb.go
  • build/temporal/api/taskqueue/v1/message.pb.go is excluded by !**/*.pb.go
  • build/temporal/api/worker/v1/message.pb.go is excluded by !**/*.pb.go
  • build/temporal/api/workflow/v1/message.pb.go is excluded by !**/*.pb.go
  • build/temporal/api/workflowservice/v1/request_response.pb.go is excluded by !**/*.pb.go
  • build/temporal/api/workflowservice/v1/service.pb.go is excluded by !**/*.pb.go
  • build/temporal/api/workflowservice/v1/service_grpc.pb.go is excluded by !**/*.pb.go
  • build/temporal/v1/temporal.pb.go is excluded by !**/*.pb.go
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • go.mod (1 hunks)
  • proto/temporal/v1/temporal.proto (1 hunks)
  • third_party/api (1 hunks)
🔇 Additional comments (4)
third_party/api (1)

1-1: Verify the submodule update contains the expected proto changes.

This submodule bump pulls generated proto code. Ensure the new commit includes:

  • New wwpid field in the temporal Message definition (as mentioned in the summary)
  • Alignment with Temporal API v1.57
  • No unintended or breaking changes to existing message structures

Additionally, confirm that the dependency version bumps in go.mod (mentioned in the summary) are coherent with these proto changes and that any backward-incompatible changes are documented.

You can verify by:

  1. Inspecting the referenced commit in the third_party/api repository
  2. Confirming the CHANGELOG documents any API-breaking changes
  3. Running integration tests to ensure downstream code remains compatible
proto/temporal/v1/temporal.proto (1)

47-48: Field addition is syntactically sound and properly documented.

The new wwpid field follows proper proto3 conventions:

  • Sequential field numbering (14 after 13)
  • Clear documentation
  • Appropriate type for workflow worker PID (uint64)
  • Additive change maintains backward-compatibility

Confirm that this field addition aligns with Temporal API v1.57.0 schema changes by verifying the generated Go code compiles and the field is properly serialized in the Temporal message contract.

go.mod (2)

3-3: Clarify the Go version pinning strategy.

Line 3 specifies go 1.24.0 (patch version) while line 5 specifies toolchain go1.24.2. Typically, the module-level go directive uses major.minor only (e.g., go 1.24), with the toolchain directive managing specific patch versions.

Verify whether the 1.24.0 specification is intentional or should be 1.24 to allow minor patch updates within the Go 1.24 series.

Also applies to: 5-5


11-11: Disregard this review comment; it mischaracterizes the dependency relationship.

The review incorrectly asks to "confirm that Temporal API v1.57.0 requires these specific versions of gRPC and Protobuf." The go.mod file specifies what this module (roadrunner-server/api/v4) requires, not what Temporal requires of its own dependencies. Temporal v1.57.0 has its own go.mod with its own constraints, which are satisfied when go mod verify passes with no conflicts—which it does.

The verification confirms: go mod tidy && go mod verify completed successfully with "all modules verified" and no dependency conflicts. The updated versions are compatible with Temporal v1.57.0 as evidenced by the successful dependency resolution.

Likely an incorrect or invalid review comment.

@rustatian rustatian merged commit 616a209 into master Nov 6, 2025
1 check passed
@rustatian rustatian deleted the feature/temporal-update branch November 6, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants