-
-
Notifications
You must be signed in to change notification settings - Fork 3
chore: regenerate proto #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
WalkthroughThe pull request updates the Go toolchain to version 1.24.2, bumps multiple dependencies including Temporal API, gRPC, and protobuf to newer versions, adds a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (14)
build/temporal/api/common/v1/message.pb.gois excluded by!**/*.pb.gobuild/temporal/api/deployment/v1/message.pb.gois excluded by!**/*.pb.gobuild/temporal/api/enums/v1/task_queue.pb.gois excluded by!**/*.pb.gobuild/temporal/api/history/v1/message.pb.gois excluded by!**/*.pb.gobuild/temporal/api/namespace/v1/message.pb.gois excluded by!**/*.pb.gobuild/temporal/api/nexus/v1/message.pb.gois excluded by!**/*.pb.gobuild/temporal/api/taskqueue/v1/message.pb.gois excluded by!**/*.pb.gobuild/temporal/api/worker/v1/message.pb.gois excluded by!**/*.pb.gobuild/temporal/api/workflow/v1/message.pb.gois excluded by!**/*.pb.gobuild/temporal/api/workflowservice/v1/request_response.pb.gois excluded by!**/*.pb.gobuild/temporal/api/workflowservice/v1/service.pb.gois excluded by!**/*.pb.gobuild/temporal/api/workflowservice/v1/service_grpc.pb.gois excluded by!**/*.pb.gobuild/temporal/v1/temporal.pb.gois excluded by!**/*.pb.gogo.sumis excluded by!**/*.sum
📒 Files selected for processing (3)
go.mod(1 hunks)proto/temporal/v1/temporal.proto(1 hunks)third_party/api(1 hunks)
🔇 Additional comments (4)
third_party/api (1)
1-1: Verify the submodule update contains the expected proto changes.This submodule bump pulls generated proto code. Ensure the new commit includes:
- New
wwpidfield in the temporal Message definition (as mentioned in the summary)- Alignment with Temporal API v1.57
- No unintended or breaking changes to existing message structures
Additionally, confirm that the dependency version bumps in
go.mod(mentioned in the summary) are coherent with these proto changes and that any backward-incompatible changes are documented.You can verify by:
- Inspecting the referenced commit in the third_party/api repository
- Confirming the CHANGELOG documents any API-breaking changes
- Running integration tests to ensure downstream code remains compatible
proto/temporal/v1/temporal.proto (1)
47-48: Field addition is syntactically sound and properly documented.The new
wwpidfield follows proper proto3 conventions:
- Sequential field numbering (14 after 13)
- Clear documentation
- Appropriate type for workflow worker PID (uint64)
- Additive change maintains backward-compatibility
Confirm that this field addition aligns with Temporal API v1.57.0 schema changes by verifying the generated Go code compiles and the field is properly serialized in the Temporal message contract.
go.mod (2)
3-3: Clarify the Go version pinning strategy.Line 3 specifies
go 1.24.0(patch version) while line 5 specifiestoolchain go1.24.2. Typically, the module-levelgodirective usesmajor.minoronly (e.g.,go 1.24), with thetoolchaindirective managing specific patch versions.Verify whether the
1.24.0specification is intentional or should be1.24to allow minor patch updates within the Go 1.24 series.Also applies to: 5-5
11-11: Disregard this review comment; it mischaracterizes the dependency relationship.The review incorrectly asks to "confirm that Temporal API v1.57.0 requires these specific versions of gRPC and Protobuf." The go.mod file specifies what this module (roadrunner-server/api/v4) requires, not what Temporal requires of its own dependencies. Temporal v1.57.0 has its own go.mod with its own constraints, which are satisfied when
go mod verifypasses with no conflicts—which it does.The verification confirms:
go mod tidy && go mod verifycompleted successfully with "all modules verified" and no dependency conflicts. The updated versions are compatible with Temporal v1.57.0 as evidenced by the successful dependency resolution.Likely an incorrect or invalid review comment.
Reason for This PR
Description of Changes
[Author TODO: add description of changes.]License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).CHANGELOG.md.Summary by CodeRabbit
Release Notes
New Features
Chores