gain_gui_egui panics when opening editor on macOS

[ahihi]

macOS 14.7.6. this log is from Carla but the same happens in Bitwig and Reason:

16:03:56 [TRACE] (2) nih_plug::wrapper::vst3::wrapper: [/Users/ahihi/Code/nih-plug/src/wrapper/vst3/wrapper.rs:486] Saved state (117 bytes)
16:04:02 [WARN] nih_plug::wrapper::vst3::view: Debug assertion failed: Ignoring host request to set explicit DPI scaling factor
16:04:02 [DEBUG] (2) egui_glow::painter: 
opengl version: 4.1 INTEL-18.8.4
opengl renderer: Intel HD Graphics 5000 OpenGL Engine
opengl vendor: Intel Inc.
16:04:02 [DEBUG] (2) egui_glow::shader_version: Shader version: Gl140 ("4.10").
16:04:02 [DEBUG] (2) egui_glow::painter: Shader header: "#version 140\n".
16:04:02 [TRACE] (2) egui_glow::painter: [/Users/ahihi/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/egui_glow-0.31.0/src/painter.rs:174] OpenGL extensions: {"GL_ARB_tessellation_shader", "GL_APPLE_container_object_shareable", "GL_EXT_framebuffer_multisample_blit_scaled", "GL_ARB_sample_shading", "GL_ATI_texture_mirror_once", "GL_ARB_texture_buffer_object_rgb32", "GL_ARB_shader_bit_encoding", "GL_EXT_texture_compression_s3tc", "GL_ARB_internalformat_query", "GL_ARB_gpu_shader5", "GL_ARB_sampler_objects", "GL_ARB_texture_storage", "GL_ARB_texture_swizzle", "GL_ARB_transform_feedback2", "GL_ARB_vertex_type_2_10_10_10_rev", "GL_ARB_viewport_array", "GL_ARB_occlusion_query2", "GL_ARB_shading_language_include", "GL_ARB_draw_buffers_blend", "GL_ARB_draw_indirect", "GL_ARB_texture_cube_map_array", "GL_ARB_texture_gather", "GL_APPLE_row_bytes", "GL_APPLE_object_purgeable", "GL_ARB_timer_query", "GL_EXT_debug_marker", "GL_ARB_blend_func_extended", "GL_APPLE_client_storage", "GL_ARB_explicit_attrib_location", "GL_APPLE_rgb_422", "GL_APPLE_texture_range", "GL_EXT_texture_sRGB_decode", "GL_ARB_instanced_arrays", "GL_NV_texture_barrier", "GL_ARB_texture_query_lod", "GL_ARB_separate_shader_objects", "GL_EXT_debug_label", "GL_EXT_texture_filter_anisotropic", "GL_ARB_gpu_shader_fp64", "GL_APPLE_flush_render", "GL_ARB_texture_rgb10_a2ui", "GL_ARB_transform_feedback3", "GL_ARB_vertex_attrib_64bit", "GL_ARB_shader_subroutine", "GL_ARB_ES2_compatibility"}
16:04:02 [DEBUG] (2) egui_glow::painter: SRGB texture Support: true
16:04:02 [DEBUG] (2) egui_glow::painter: SRGB framebuffer Support: false
16:04:02 [DEBUG] (2) egui_glow::vao: GL version: "4.1 INTEL-18.8.4".
16:04:03 [ERROR] nih_plug::wrapper::util: thread 'unnamed' panicked at 'null pointer dereference occurred': /Users/ahihi/.cargo/git/checkouts/baseview-497883493ac32f43/9a0b42c/src/macos/view.rs:248
0: backtrace::backtrace::libunwind::trace
at /Users/ahihi/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/backtrace-0.3.74/src/backtrace/libunwind.rs:116:5
backtrace::backtrace::trace_unsynchronized
at /Users/ahihi/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/backtrace-0.3.74/src/backtrace/mod.rs:66:5
1: backtrace::backtrace::trace
at /Users/ahihi/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/backtrace-0.3.74/src/backtrace/mod.rs:53:14
2: backtrace::capture::Backtrace::create
at /Users/ahihi/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/backtrace-0.3.74/src/capture.rs:292:9
3: backtrace::capture::Backtrace::new
at /Users/ahihi/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/backtrace-0.3.74/src/capture.rs:257:22
4: nih_plug::wrapper::util::log_panics::{{closure}}::{{closure}}
at /Users/ahihi/Code/nih-plug/src/wrapper/util.rs:148:29
5: assert_no_alloc::permit_alloc
at /Users/ahihi/.cargo/git/checkouts/rust-assert-no-alloc-326423a65fd2fe4b/a6fb4f6/src/lib.rs:113:12
6: nih_plug::util::permit_alloc
at /Users/ahihi/Code/nih-plug/src/util.rs:18:5
7: nih_plug::wrapper::util::log_panics::{{closure}}
at /Users/ahihi/Code/nih-plug/src/wrapper/util.rs:145:9
8: <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call
at /rustc/1159e78c4747b02ef996e55082b704c09b970588/library/alloc/src/boxed.rs:1985:9
std::panicking::rust_panic_with_hook
at /rustc/1159e78c4747b02ef996e55082b704c09b970588/library/std/src/panicking.rs:841:13
9: std::panicking::begin_panic_handler::{{closure}}
at /rustc/1159e78c4747b02ef996e55082b704c09b970588/library/std/src/panicking.rs:699:13
10: std::sys::backtrace::__rust_end_short_backtrace
at /rustc/1159e78c4747b02ef996e55082b704c09b970588/library/std/src/sys/backtrace.rs:174:18
11: __rustc::rust_begin_unwind
at /rustc/1159e78c4747b02ef996e55082b704c09b970588/library/std/src/panicking.rs:697:5
12: core::panicking::panic_nounwind_fmt::runtime
at /rustc/1159e78c4747b02ef996e55082b704c09b970588/library/core/src/panicking.rs:117:22
core::panicking::panic_nounwind_fmt
at /rustc/1159e78c4747b02ef996e55082b704c09b970588/library/core/src/intrinsics/mod.rs:2367:9
13: core::panicking::panic_null_pointer_dereference
at /rustc/1159e78c4747b02ef996e55082b704c09b970588/library/core/src/panicking.rs:311:5
14: baseview::macos::view::become_first_responder
at /Users/ahihi/.cargo/git/checkouts/baseview-497883493ac32f43/9a0b42c/src/macos/view.rs:248:35
15: <unknown>
16: <(A,) as objc::message::MessageArguments>::invoke
at /Users/ahihi/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/objc-0.2.7/src/message/mod.rs:128:17
17: objc::message::platform::send_unverified
at /Users/ahihi/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/objc-0.2.7/src/message/apple/mod.rs:27:9
18: objc::message::send_message
at /Users/ahihi/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/objc-0.2.7/src/message/mod.rs:178:5
baseview::macos::view::view_will_move_to_window
at /Users/ahihi/.cargo/git/checkouts/baseview-497883493ac32f43/9a0b42c/src/macos/view.rs:369:25
19: <unknown>
20: <unknown>
21: <(A,) as objc::message::MessageArguments>::invoke
at /Users/ahihi/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/objc-0.2.7/src/message/mod.rs:128:17
22: objc::message::platform::send_unverified
at /Users/ahihi/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/objc-0.2.7/src/message/apple/mod.rs:27:9
23: objc::message::send_message
at /Users/ahihi/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/objc-0.2.7/src/message/mod.rs:178:5
baseview::macos::window::Window::open_parented
at /Users/ahihi/.cargo/git/checkouts/baseview-497883493ac32f43/9a0b42c/src/macos/window.rs:170:25
24: baseview::window::Window::open_parented
at /Users/ahihi/.cargo/git/checkouts/baseview-497883493ac32f43/9a0b42c/src/window.rs:77:29
25: egui_baseview::window::EguiWindow<State,U>::open_parented
at /Users/ahihi/.cargo/git/checkouts/egui-baseview-fde77becaa39f49a/ec70c3f/src/window.rs:236:9
26: <nih_plug_egui::editor::EguiEditor<T> as nih_plug::editor::Editor>::spawn
at /Users/ahihi/Code/nih-plug/nih_plug_egui/src/editor.rs:76:22
27: <nih_plug::wrapper::vst3::view::WrapperView<P> as vst3_sys::gui::iplugview::IPlugView>::attached
at /Users/ahihi/Code/nih-plug/src/wrapper/vst3/view.rs:305:22  28: <dyn vst3_sys::gui::iplugview::IPlugView as vst3_com::ProductionComInterface<C>>::vtable::iplugview_attached
at /Users/ahihi/.cargo/git/checkouts/vst3-sys-7c1833a33d74d639/b3ff4d7/src/gui/iplugview.rs:15:1
29: __ZN4asio6detail16service_registry6createINS0_23reactive_socket_serviceINS_2ip3udpEEENS_10io_contextEEEPNS_17execution_context7serviceEPv
30: __ZN4asio6detail16service_registry6createINS0_23reactive_socket_serviceINS_2ip3udpEEENS_10io_contextEEEPNS_17execution_context7serviceEPv
31: __ZN4asio6detail16service_registry6createINS0_23reactive_socket_serviceINS_2ip3udpEEENS_10io_contextEEEPNS_17execution_context7serviceEPv
32: __ZN4asio6detail16service_registry6createINS0_23reactive_socket_serviceINS_2ip3udpEEENS_10io_contextEEEPNS_17execution_context7serviceEPv
33: __ZN12CarlaBackend11CarlaPlugin7newJuceERKNS0_11InitializerEPKc
34: __ZN12CarlaBackend11CarlaPlugin7newJuceERKNS0_11InitializerEPKc
35: _carla_show_custom_ui
36: <unknown>
37: <unknown>
38: <unknown>
39: <unknown>
40: __PyObject_MakeTpCall
41: __PyEval_EvalFrameDefault
42: __PyEval_EvalFrameDefault
43: __PyFunction_Vectorcall
44: _PyMethod_New
45: __PyEval_EvalFrameDefault
46: __PyEval_EvalFrameDefault
47: __PyFunction_Vectorcall
48: _PyMethod_New
49: __ZNK8PyQtSlot4callEP7_objectS1_
50: __ZNK8PyQtSlot6invokeEPPvP7_objectS0_b
51: __ZNK8PyQtSlot6invokeEPPvP7_objectS0_
52: __ZL18qt_metacall_workerP17_sipSimpleWrapperP11_typeobjectP11_sipTypeDefN11QMetaObject4CallEiPPv
53: __ZL18qt_metacall_workerP17_sipSimpleWrapperP11_typeobjectP11_sipTypeDefN11QMetaObject4CallEiPPv
54: __Z27qpycore_qobject_qt_metacallP17_sipSimpleWrapperP11_sipTypeDefN11QMetaObject4CallEiPPv
55: __ZN11QMetaObject8activateEP7QObjectiiPPv
56: __ZNK15QAbstractButton11isCheckableEv
57: __ZNK15QAbstractButton11isCheckableEv
58: __ZN15QAbstractButton17mouseReleaseEventEP11QMouseEvent
59: __ZN14sipQPushButton17mouseReleaseEventEP11QMouseEvent
60: __ZN7QWidget5eventEP6QEvent
61: __ZN14sipQPushButton5eventEP6QEvent
62: __ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent
63: __ZN12QApplication6notifyEP7QObjectP6QEvent
64: __ZN15sipQApplication6notifyEP7QObjectP6QEvent
65: __ZN16QCoreApplication15notifyInternal2EP7QObjectP6QEvent
66: __ZN19QApplicationPrivate14sendMouseEventEP7QWidgetP11QMouseEventS1_S1_PS1_R8QPointerIS0_Ebb
67: __ZN14QDesktopWidget11qt_metacallEN11QMetaObject4CallEiPPv
68: __ZN14QDesktopWidget11qt_metacallEN11QMetaObject4CallEiPPv
69: __ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent
70: __ZN12QApplication6notifyEP7QObjectP6QEvent
71: __ZN15sipQApplication6notifyEP7QObjectP6QEvent
72: __ZN16QCoreApplication15notifyInternal2EP7QObjectP6QEvent
73: __ZN22QGuiApplicationPrivate17processMouseEventEPN29QWindowSystemInterfacePrivate10MouseEventE
74: __ZN22QGuiApplicationPrivate17processMouseEventEPN29QWindowSystemInterfacePrivate10MouseEventE
75: __ZN22QWindowSystemInterface22sendWindowSystemEventsE6QFlagsIN10QEventLoop17ProcessEventsFlagEE
76: _qt_plugin_instance
77: <unknown>
78: <unknown>
79: <unknown>
80: <unknown>
81: <unknown>
82: <unknown>
83: <unknown>
84: <unknown>
85: <unknown>
86: <unknown>
87: <unknown>
88: _qt_plugin_instance
89: __ZN10QEventLoop4execE6QFlagsINS_17ProcessEventsFlagEE
90: __ZN16QCoreApplication4execEv
91: __ZL23meth_QApplication_exec_P7_objectS0_
92: _PyCFunction_GetFunction
93: __PyObject_MakeTpCall
94: __PyEval_EvalFrameDefault
95: __PyEval_EvalFrameDefault
96: __PyFunction_Vectorcall
97: __PyEval_EvalFrameDefault
98: __PyEval_EvalFrameDefault
99: __PyEval_EvalFrameDefault
100: _PyEval_EvalCode
101: __PyAST_Optimize
102: _PyCMethod_New
103: __PyEval_EvalFrameDefault
104: __PyEval_EvalFrameDefault
105: __PyFunction_Vectorcall
106: __PyEval_EvalFrameDefault
107: __PyEval_EvalFrameDefault
108: __PyFunction_Vectorcall
109: _PyObject_CallObject
110: _main
111: <unknown>

[ahihi]

i updated the baseview and egui-baseview deps of nih_plug_egui:

baseview = { git = "https://github.com/RustAudio/baseview.git", rev = "3724a00c970a9cd10a3494fa3c37bca66d631bb7" }
# ...
egui-baseview = { git = "https://codeberg.org/BillyDM/egui-baseview.git", rev = "b6bcb51312bf9b2b710753475f7efb4cfe39ddef" }

and rebuilt. it works now!

should i make a PR for this, or is there some reason to stay on the older versions?

[cesarpx]

Hi @ahihi,

I was having the same issue, and your change works on my end as well. However, I noticed there’s already an existing PR with this exact fix:
#224

For now, I’m referencing that branch until it gets merged. I’ll also leave a comment there linking to this issue to help with visibility.

Thanks so much for sharing your solution!

[timboudreau]

Running into the same thing with a vizia UI on an M1 Macbook, run with nih_export_standalone() and also discovered that updating the depended on commit to the current head of baseview solves it.

[z-jxy]

Also having this issue on M4 Macbook