Enable msvc build#2
Merged
Merged
Conversation
To silence some warnings
By not using posix specific file open/read/close
Avoids mixing headers from system and local version Add option to force building included zlib Build as static library
Possibly only needed for MSVC
Since pthreads are not available
Collaborator
Author
robbr48
approved these changes
Apr 29, 2022
Owner
robbr48
left a comment
robbr48
left a comment
There was a problem hiding this comment.
Now I finally looked through it, and everything looks good as far as I can see. fmi4c.h is very hard to review since more or less everything has changed, but I assume it is mostly about replacing FMIC_DLLEXPORT.
Collaborator
Author
|
Yes the last tow commits were indentation changes and renamed the export macro |
slitvinov
added a commit
to slitvinov/fmi4c
that referenced
this pull request
May 2, 2026
Without this, test FMUs are written to binaries/linux64 (FMI 1/2) or binaries/x86_64-linux (FMI 3) on macOS, while the patched fmi4c reader correctly looks under binaries/darwin64 / aarch64-darwin. With this commit and the reader fix applied, all 6 ctest cases pass on macOS 26.4.1 arm64 (Apple M5): Test #1: fmi1cs ........... Passed 1.05 sec Test robbr48#2: fmi1me ........... Passed 0.36 sec Test robbr48#3: fmi2cs ........... Passed 0.44 sec Test robbr48#4: fmi2me ........... Passed 0.46 sec Test robbr48#5: fmi3cs ........... Passed 0.42 sec Test robbr48#6: fmi3me ........... Passed 0.33 sec 100% tests passed, 0 tests failed out of 6
robbr48
pushed a commit
that referenced
this pull request
May 20, 2026
Without this, test FMUs are written to binaries/linux64 (FMI 1/2) or binaries/x86_64-linux (FMI 3) on macOS, while the patched fmi4c reader correctly looks under binaries/darwin64 / aarch64-darwin. With this commit and the reader fix applied, all 6 ctest cases pass on macOS 26.4.1 arm64 (Apple M5): Test #1: fmi1cs ........... Passed 1.05 sec Test #2: fmi1me ........... Passed 0.36 sec Test #3: fmi2cs ........... Passed 0.44 sec Test #4: fmi2me ........... Passed 0.46 sec Test #5: fmi3cs ........... Passed 0.42 sec Test #6: fmi3me ........... Passed 0.33 sec 100% tests passed, 0 tests failed out of 6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various change to enable build with MSVC
Add option to force use of included zlib, version found in system is used otherwise.
I not found, the included version if build by default (for MSVC). It is build as a static library in this case.