Adding Stockport to new_branch#17
Merged
Merged
Conversation
4 tasks
4 tasks
4 tasks
4 tasks
4 tasks
4 tasks
4 tasks
4 tasks
4 tasks
This was referenced Jan 8, 2026
4 tasks
4 tasks
4 tasks
This was referenced Feb 9, 2026
pull Bot
pushed a commit
to mrw298/UKBinCollectionData
that referenced
this pull request
May 1, 2026
…x date parsing, improve address matching time.sleep(5) after clicking Find Address held Chrome idle at peak memory while the parallel Grid+local Chrome paths overlapped — causing the robbrad#17 __clone OOM crash in the Selenium Grid container. The dropdown populates in ~0.4s in practice, so the 5s sleep was pure idle contention. Changes: - Replace sleep(5) with WebDriverWait polling for a populated <select> (>1 option), cutting ~4.5s off each run and eliminating the overlap window that triggered the Grid crash - Add a second wait for at least one .card h3 after selecting the address, since JS builds collection cards asynchronously after the select change - Fix date parsing: use _DATE_RE regex to extract every well-formed date from each <p> — a single tag can contain multiple comma-separated dates in the 'Following Collections:' case; old split(':') approach raised 'unconverted data remains' errors in those cases - Improve address matching priority: exact prefix > comma-bounded > A-suffix > substring, so '91 THE COMMON' beats 'ANNEXE 91 THE COMMON' when searching for house number 91 - Remove unused import time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.