fix: UttlesfordDistrictCouncil year and bin type parsing

[Russell-IO]

UttlesfordDistrictCouncil

• Fix hardcoded year 2024 - now dynamically uses current/next year based on whether date has passed
• Use date-only comparison to avoid incorrectly treating today's collections as past
• Fix incorrect bin types - extract color from image filename (brown, black, green) instead of relying on erroneous alt text

EastHertsCouncil

• Skip empty NextDate values in API response to prevent datetime parsing errors

Summary by CodeRabbit

Bug Fixes

• Fixed potential errors when processing missing or empty collection dates
• Improved bin type detection and collection date parsing accuracy
• Enhanced year calculation logic for collection date handling

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

Uttlesford parser: derive bin types from image filenames and compute collection year dynamically (use current year, increment if parsed date already passed). East Herts parser: skip rows with empty/whitespace "NextDate" values to avoid creating invalid BinType/collection entries.

Changes

Cohort / File(s)	Summary
Uttlesford parser uk_bin_collection/uk_bin_collection/councils/UttlesfordDistrictCouncil.py	Added from datetime import datetime; resolve bin types from image src filenames (fallback to alt); replace hard-coded year with current-year logic and increment year if parsed date is in the past; update final collectionDate formatting.
East Herts parser guard uk_bin_collection/uk_bin_collection/councils/EastHertsCouncil.py	Added guard in parse_data to skip processing when *NextDate value is empty or only whitespace, preventing construction of invalid BinType/date entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• dp247

Poem

🐇 I hop through filenames and dates so bright,

I sniff the src and find the bin just right,
If last year's left, I bound to the new,
I skip the blanks and tidy up the queue,
🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main changes in the pull request: fixing year and bin type parsing in UttlesfordDistrictCouncil.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.67%. Comparing base (274152f) to head (0f38797).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1823   +/-   ##
=======================================
  Coverage   86.67%   86.67%           
=======================================
  Files           9        9           
  Lines        1141     1141           
=======================================
  Hits          989      989           
  Misses        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Copilot]

Pull request overview

Fixes incorrect bin collection years for Uttlesford District Council by removing a hardcoded 2024 and selecting the appropriate year dynamically.

Changes:

• Replace hardcoded year 2024 with the current year at runtime.
• Roll collection dates into the next year when the computed date has already passed.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The collection_date < datetime.now() comparison includes the current time-of-day, but collection_date is parsed with a default time of 00:00. This means a collection scheduled for today will almost always be treated as “already passed” and have its year incremented. Consider capturing now = datetime.now() once and comparing collection_date.date() < now.date() (or otherwise normalizing times) before applying the +1 year adjustment.

Suggested change

	current_year = datetime.now().year
	collection_date = collection_date.replace(year=current_year)
	if collection_date < datetime.now():
	now = datetime.now()
	current_year = now.year
	collection_date = collection_date.replace(year=current_year)
	if collection_date.date() < now.date():

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@uk_bin_collection/uk_bin_collection/councils/UttlesfordDistrictCouncil.py`:
- Around line 96-100: The code uses datetime.strptime(...) to build
collection_date (midnight) then compares it to datetime.now() (includes time),
causing a collection on the current day to be seen as past and rolled to next
year; fix by capturing today = datetime.now().date() once and compare
collection_date.date() to today (or assign the year using today's year and if
collection_date.date() < today then use today.year + 1) so the comparison is
date-only. Update the logic around collection_date, collection_date_str,
datetime.strptime and datetime.now() to use the single captured today value and
date() comparisons.

🧹 Nitpick comments (1)

uk_bin_collection/uk_bin_collection/councils/UttlesfordDistrictCouncil.py (1)

96-100: Consider making the datetime import explicit for clarity.

While datetime is available via the star import from common.py, explicitly importing from datetime import datetime makes the dependency clearer and reduces reliance on star imports—a best practice for maintainability.

🔧 Suggested change

+from datetime import datetime
 from uk_bin_collection.uk_bin_collection.common import *

[robbrad]

This PR has been merged into the February 2026 consolidated release PR #1837.

Thank you for your contribution!