fix: ChelmsfordCityCouncil - dismiss email-signup modal blocking form#1973
fix: ChelmsfordCityCouncil - dismiss email-signup modal blocking form#1973InertiaUK wants to merge 1 commit into
Conversation
chelmsford.gov.uk now renders a 'Sign up to City News' modal dialog on the check-your-collection-day page that overlays the postcode search form. The existing cookie-accept step doesn't close it, so when the scraper tries to send_keys into the postcode input it raises ElementNotInteractableException. Close the modal via its Close button (role-qualified XPath so we don't hit the success-banner close button), and guard the postcode input / search click with JS fallbacks in case any other overlay intercepts the native click.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 58 minutes and 57 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Included in May 2026 Release PR #1992. Closing. |
…equests (supersedes robbrad#1973)
2 participants
Problem
www.chelmsford.gov.uk/bins-and-recycling/check-your-collection-day/now renders a "Sign up to City News" modal dialog (Website popup 3) on page load. It overlays the postcode search form, so after the cookie-accept step the scraper'spostcode_input.send_keys(postcode)raises:```
selenium.common.exceptions.ElementNotInteractableException: Message: element not interactable
```
The existing cookie-accept click doesn't close this modal.
Fix
Close the modal via its Close button before interacting with the form. Scope the XPath to
//dialog//buttonso we don't accidentally click the site's unrelated "Close success" banner button, and match on eitheraria-label=\"Close\"or visible textClose.Also add JS fallbacks for the postcode input and Search button in case any other overlay intercepts a native click — minor hardening only.
Verification
Fixture postcode
CM3 7AE+ full-address paon (per wiki_note,1 Celeborn Street, South Woodham Ferrers, Chelmsford, CM3 7AE) returns the expected Tuesday B calendar (multiple upcoming collections for food waste / brown bin / plastics / etc).