fix: RotherhamCouncil - rewrite for Imactivate API (postcode + paon)#1981
fix: RotherhamCouncil - rewrite for Imactivate API (postcode + paon)#1981InertiaUK wants to merge 1 commit into
Conversation
Rotherham's own bin-day page directs residents to PDF calendars only — there is no usable web lookup at rotherham.gov.uk. The Rotherham Bins mobile app uses the shared Imactivate backend at `bins.azurewebsites.net`. Earlier this year that endpoint had no Rotherham data deployed; as of April 2026 it does: - `getaddress?postcode=S60+1JD&localauthority=Rotherham` returns the full address list with `PremiseID` per row. - `getcollections?premisesid=<id>&localauthority=Rotherham` returns 6 future collections (PINK / BLACK / GREEN bins) per property. The previous scraper only accepted a `premisesid` (or treated a numeric `uprn` as one), but standard UPRNs are not Imactivate PremiseIDs and yield empty results. Rewritten to accept `postcode` + `paon`, resolve the PremiseID via getaddress (matching against Address1 / Address2 / Street with a substring fallback for compound addresses like "Flat 3, 22A"), then fetch the schedule. `premisesid` is still honoured if explicitly passed. `input.json` updated to use postcode `S60 1JD` + paon `77` so the parity check stays green and the integration test can hit the live API. Verified: returns the full upcoming bin schedule.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 57 minutes and 54 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Included in May 2026 Release PR #1992. Closing. |
2 participants
Rotherham's own bin-day page (
rotherham.gov.uk/bin-collections) directs residents to PDF calendars only — there is no usable web lookup. The data behind the Rotherham Bins Android app comes from the shared Imactivate backend atbins.azurewebsites.net. Earlier in the year that endpoint had no Rotherham data deployed; as of April 2026 it does:GET /api/getaddress?postcode=S60+1JD&localauthority=Rotherhamreturns the full address list withPremiseIDper row.GET /api/getcollections?premisesid=<id>&localauthority=Rotherhamreturns the upcoming schedule (PINK / BLACK / GREEN bins).The existing scraper only accepted a pre-resolved
premisesid(or treated a numericuprnas one). Standard UPRNs are not Imactivate PremiseIDs and yield empty results, which is why the test had been failing. Rewritten to acceptpostcode+paon:getaddress, matching againstAddress1/Address2/Street, with a looser substring fallback for compound addresses likeFlat 3, 22A.getcollections.premisesidkwarg if passed.input.jsonupdated to usepostcode: S60 1JD+paon: 77so the parity check stays green and the integration test can exercise the live API. Verified end-to-end: returns 6 future collections.