Skip to content

fix: BroxtoweBoroughCouncil - fall back to house number text match#1993

Closed
InertiaUK wants to merge 1 commit into
robbrad:masterfrom
InertiaUK:fix/BroxtoweBoroughCouncil-address-match
Closed

fix: BroxtoweBoroughCouncil - fall back to house number text match#1993
InertiaUK wants to merge 1 commit into
robbrad:masterfrom
InertiaUK:fix/BroxtoweBoroughCouncil-address-match

Conversation

@InertiaUK
Copy link
Copy Markdown
Contributor

The scraper selected addresses by UPRN value in the dropdown (select_by_value("U" + uprn)), which fails when the resolved UPRN doesn't match the council's dropdown option values.

Now tries UPRN match first, then falls back to matching dropdown option text by house number prefix (case-insensitive).

Testing: Verified with NG9 3QR / 25 Derbyshire Avenue — returns 3 bins.

… dropdown

The scraper selected addresses by UPRN value in the dropdown, which fails
when the resolved UPRN doesn't exactly match one of the council's dropdown
option values. Now tries UPRN match first, then falls back to matching the
dropdown option text by house number prefix.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 1, 2026

Warning

Rate limit exceeded

@InertiaUK has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 60 minutes before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cae9960a-0329-46c5-bb91-b76aaa0e6938

📥 Commits

Reviewing files that changed from the base of the PR and between d661bf1 and 5ec9894.

📒 Files selected for processing (3)
  • uk_bin_collection/uk_bin_collection/councils/BroxtoweBoroughCouncil.py
  • uk_bin_collection/uk_bin_collection/councils/StirlingCouncil.py
  • uk_bin_collection/uk_bin_collection/councils/UttlesfordDistrictCouncil.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.67%. Comparing base (ea4cd4c) to head (5ec9894).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1993   +/-   ##
=======================================
  Coverage   86.67%   86.67%           
=======================================
  Files           9        9           
  Lines        1141     1141           
=======================================
  Hits          989      989           
  Misses        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robbrad
Copy link
Copy Markdown
Owner

robbrad commented May 2, 2026

Included in May 2026 Release (PR #1992). Closing.

@robbrad robbrad closed this May 2, 2026
@robbrad robbrad mentioned this pull request May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants