[WIP] Add table metadata to cmiyc#118
Open
khalidharun wants to merge 18 commits intorobertzk:masterfrom
Open
Conversation
added 2 commits
December 2, 2015 16:24
Owner
There was a problem hiding this comment.
> serialize("foo")
Error in serialize("foo") :
argument "connection" is missing, with no defaultdon't you need NULL as the second argument to serialize?
Owner
|
Few minor comments. Can you get tests passing? |
Owner
There was a problem hiding this comment.
I would make this a separate function.
Owner
There was a problem hiding this comment.
ensure_cache_metadata_table_exists()
Owner
|
Some minor comments but otherwise good. |
…an into table_metadata
Collaborator
|
@khalidharun @robertzk Ping? |
|
|
||
| get_table_name <- memoise::memoise(table_name_) | ||
|
|
||
| #' TODO: Depricate in favor of get_table_name |
Owner
There was a problem hiding this comment.
Can you remove the roxygen in this comment?
Owner
|
@khalidharun Can you address comments> |
Owner
|
Will merge after addressed. |
Collaborator
|
Definitely should backmerge master now that #115 is merged |
Owner
|
@khalidharun can you do so? Don't have control from over here. |
Owner
|
@khalidharun welcome to the inner circle.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to shed some more light into what the
table_namerefers back to, let's start storing some table metadata which will store the salt values.