removes dictionary key for subhelm and uses selectorsInherited#576
Merged
mumoshu merged 2 commits intoroboll:masterfrom May 6, 2019
Merged
Conversation
sgandon
force-pushed
the
sgandon/removes_dic_key_subhelmfile
branch
from
3507c68 to
b2a085a
Compare
mumoshu
reviewed
May 6, 2019
| default: | ||
| return fmt.Errorf("Expecting list of strings or and empty {} mapping [-%v] but got: [%v] of type [%T] ", hf.Path, selectors, selectors) | ||
| //also exclude SelectorsInherited to true and explicit selectors | ||
| if hf.SelectorsInherited && len(hf.Selectors) > 0 { |
Contributor
Author
There was a problem hiding this comment.
@mumoshu about this. I was wondering if we could not accept inheritance and selectors like this
helmfiles:
- path: /infrastructure-helmfile.yaml
selectors:
- name=grafana
- name=prometheus
SelectorsInherited : true
where if nothing comes from the parent helmfile or the command line then only grafana and prometheus are selected and if there is parent selectors then they would be combined together, meaning inherited selectors added to the default selectors.
What do you think ?
mumoshu
approved these changes
May 6, 2019
Collaborator
mumoshu
left a comment
mumoshu
left a comment
There was a problem hiding this comment.
LGTM. Thanks for following up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following @mumoshu comments here #567, I removed the usage of subhelmfile path as map key.
I also introduced the selectorsInherited key for explicit parent selector inheritance.