Skip to content

Update ArgumentConverter.java#15

Closed
eramitmittal wants to merge 1 commit intorobotframework:masterfrom
eramitmittal:master
Closed

Update ArgumentConverter.java#15
eramitmittal wants to merge 1 commit intorobotframework:masterfrom
eramitmittal:master

Conversation

@eramitmittal
Copy link
Copy Markdown

Allowing ${None} to be passed to keywords. currently it results in null pointer exception

Allowing ${None} to be passed to keywords. currently it results in null pointer exception
@jussimalinen
Copy link
Copy Markdown
Member

As we havent touched this library in a long time, I sort of forgot this issue. I'll make a new release with this before the end of the year.

@eramitmittal
Copy link
Copy Markdown
Author

Hi,

Any news on this?

Thanks,
Amit

@hleskien
Copy link
Copy Markdown

Hi,
please integrate this pull request. It may not fix all NullPointerExceptions, but at least it's a start.
Thank you,
Holger

@pekkaklarck
Copy link
Copy Markdown
Member

Unfortunately this tool hasn't been actively maintained lately. Would be great if someone could take a look at the PRs and create a new release. Have you @mihaiparvu, or your team, looked at JavalibCore at all? It's used by SwingLibrary isn't it? How about @Hi-Fi?

@Hi-Fi
Copy link
Copy Markdown
Contributor

Hi-Fi commented Nov 18, 2019

Sorry, I missed this completely when checked the code.

All my libraries are using this, and there are some things I have thought that need fixing for some time. E.g. argument parsing.

@pekkaklarck
Copy link
Copy Markdown
Member

pekkaklarck commented Nov 18, 2019

Are you @Hi-Fi interested in taking maintainer responsibilities, possibly with help from @mihaiparvu? I'm sure @jussimalinen can help getting started if needed.

I doubt there's that much work needed in general. First thing would be going through the issues and PRs here and possibly creating a release. RF 3.1 also introduced some new features to the library API such type support and named-only arguments. Latter releases could add support for them if they make sense in this context.

@mihaiparvu
Copy link
Copy Markdown

@pekkaklarck JavaLibCore is indeed used by SwingLibrary, but we didn't touch it at all. I don't think we even have maintainer rights on that repo. We could help test future versions with SwingLibrary, but don't have much time for development these days.

@Hi-Fi
Copy link
Copy Markdown
Contributor

Hi-Fi commented Nov 18, 2019

@pekkaklarck I can try at least.

@Hi-Fi
Copy link
Copy Markdown
Contributor

Hi-Fi commented Dec 17, 2019

ArgumentCollector removed, so this is not valid anymore.

@Hi-Fi Hi-Fi closed this Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants