Skip to content

Drop dependency on deprecated gulp-util#38

Merged
robrich merged 1 commit intorobrich:masterfrom
TheDancingCode:issue-37
Jan 5, 2018
Merged

Drop dependency on deprecated gulp-util#38
robrich merged 1 commit intorobrich:masterfrom
TheDancingCode:issue-37

Conversation

@TheDancingCode
Copy link
Copy Markdown
Contributor

Closes #37

Copy link
Copy Markdown

@demurgos demurgos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@robrich
Could we have this merged and published?

@robrich
Copy link
Copy Markdown
Owner

robrich commented Jan 5, 2018

Why fancylog.info() instead of fancylog.error() for stderr?

@demurgos
Copy link
Copy Markdown

demurgos commented Jan 5, 2018

This PR performs a simple replacement without changing any feature (fancyLog.info is the closest to gutil.log if you want to capture log calls with your tests). If you wish to change the behavior of your library feel free to do it.

We do our best to help maintainers to migrate (@TheDancingCode opened tons of PRs) but we focus on minimizing changes because this is already very time consuming. We still need to deal with failing CI or mistakes so we prefer to defer feature changes to maintainers.

Still, your request makes sense. You could merge the PR and then push your change, or wait for @TheDancingCode to fix it, or just pull/push changes on his branch (I believe you have write access).

@robrich robrich merged commit 37f29e1 into robrich:master Jan 5, 2018
@demurgos
Copy link
Copy Markdown

demurgos commented Jan 5, 2018

Thanks for merging and publishing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants