Skip to content

Project initialization#101

Merged
gavv merged 3 commits intoroc-streaming:flutterfrom
Izchomatik:project_initialization
Jul 13, 2024
Merged

Project initialization#101
gavv merged 3 commits intoroc-streaming:flutterfrom
Izchomatik:project_initialization

Conversation

@Izchomatik
Copy link
Collaborator

Flutter migration: Project initialization

Issue: #95

@Izchomatik Izchomatik self-assigned this Jul 12, 2024
@Izchomatik Izchomatik requested review from gavv and ortex July 12, 2024 17:02
@Izchomatik Izchomatik added the status: ready for review Pull request can be reviewed label Jul 12, 2024
@Izchomatik Izchomatik linked an issue Jul 12, 2024 that may be closed by this pull request
7 tasks
@Izchomatik
Copy link
Collaborator Author

Izchomatik commented Jul 12, 2024

@gavv and @ortex - please also pay attention to README.md: 19d8e92#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

P.S. - this is a working version of readme - the old readme of course will be added there at some point

@Izchomatik Izchomatik removed their assignment Jul 12, 2024
@gavv gavv added category: flutter migration Task related to migration to Flutter and removed status: ready for review Pull request can be reviewed labels Jul 12, 2024
@Izchomatik Izchomatik force-pushed the project_initialization branch 2 times, most recently from 113b396 to 3057731 Compare July 12, 2024 18:36
@Izchomatik Izchomatik force-pushed the project_initialization branch from 3057731 to 746fbc8 Compare July 12, 2024 18:51
@Izchomatik
Copy link
Collaborator Author

@gavv and @ortex - there is a lot of auto-generated code in this PR.

The hand crafted code for your check is basically in folders:

  • docs
  • lib
  • test

@gavv
Copy link
Member

gavv commented Jul 12, 2024

Two small comments, as discussed in chat:

  • avoid part of, for now
  • replace observables with final public fields

@gavv gavv merged commit ccf6e33 into roc-streaming:flutter Jul 13, 2024
@Izchomatik Izchomatik deleted the project_initialization branch February 21, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: flutter migration Task related to migration to Flutter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flutter migration: Project initialization

2 participants