feat(zero-cache): restore the ZERO_CHANGE_STREAMER_URI option#4584
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Bencher Report| Branch | darkgnotic/restore-change-streamer-uri-option |
| Testbed | Linux |
Click to view all benchmark results
| Benchmark | File Size | Benchmark Result kilobytes (KB) (Result Δ%) | Upper Boundary kilobytes (KB) (Limit %) |
|---|---|---|---|
| zero-package.tgz | 📈 view plot 🚷 view threshold | 1,212.42 KB(+0.00%)Baseline: 1,212.41 KB | 1,236.66 KB (98.04%) |
| zero.js | 📈 view plot 🚷 view threshold | 200.08 KB(0.00%)Baseline: 200.08 KB | 204.08 KB (98.04%) |
| zero.js.br | 📈 view plot 🚷 view threshold | 56.13 KB(0.00%)Baseline: 56.13 KB | 57.25 KB (98.04%) |
|
| Branch | darkgnotic/restore-change-streamer-uri-option |
| Testbed | Linux |
Click to view all benchmark results
| Benchmark | Throughput | Benchmark Result operations / second (ops/s) x 1e3 (Result Δ%) | Lower Boundary operations / second (ops/s) x 1e3 (Limit %) |
|---|---|---|---|
| src/client/custom.bench.ts > big schema | 📈 view plot 🚷 view threshold | 380.17 ops/s x 1e3(+4.25%)Baseline: 364.67 ops/s x 1e3 | 332.07 ops/s x 1e3 (87.35%) |
| src/client/zero.bench.ts > basics > All 1000 rows x 10 columns (numbers) | 📈 view plot 🚷 view threshold | 1.64 ops/s x 1e3(+2.21%)Baseline: 1.60 ops/s x 1e3 | 1.55 ops/s x 1e3 (94.65%) |
| src/client/zero.bench.ts > pk compare > pk = N | 📈 view plot 🚷 view threshold | 30.51 ops/s x 1e3(+0.24%)Baseline: 30.43 ops/s x 1e3 | 29.51 ops/s x 1e3 (96.71%) |
| src/client/zero.bench.ts > with filter > Lower rows 500 x 10 columns (numbers) | 📈 view plot 🚷 view threshold | 2.61 ops/s x 1e3(+2.95%)Baseline: 2.53 ops/s x 1e3 | 2.46 ops/s x 1e3 (94.21%) |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Dec 2, 2025
…er task registration (#5250) Restore the original `replication-manager` behavior of delaying the replication stream takeover to allow the task to be registered as a healthy target by the load balancer (i.e. after a minimum number of health checks). This fixes the temporary unreachability of the replication-manager when the handoff happens before the load-balancer has recognized the new replication-manager as healthy. This original functionality was simplified away with the introduction of auto-discovery (#4335), since that replaced the dns and proxying component, but never restored when proxy-based routing was reintroduced in #4584 (and is now the recommended configuration). This new implementation is more compartmentalized than the original implementation, encapsulating all of the logic in the ChangeStreamerHttpService, so that the ChangeStreamerService itself is agnostic to the details of health checks and startup delays.
darkgnotic
added a commit
that referenced
this pull request
Dec 2, 2025
…er task registration (#5250) Restore the original `replication-manager` behavior of delaying the replication stream takeover to allow the task to be registered as a healthy target by the load balancer (i.e. after a minimum number of health checks). This fixes the temporary unreachability of the replication-manager when the handoff happens before the load-balancer has recognized the new replication-manager as healthy. This original functionality was simplified away with the introduction of auto-discovery (#4335), since that replaced the dns and proxying component, but never restored when proxy-based routing was reintroduced in #4584 (and is now the recommended configuration). This new implementation is more compartmentalized than the original implementation, encapsulating all of the logic in the ChangeStreamerHttpService, so that the ChangeStreamerService itself is agnostic to the details of health checks and startup delays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the
ZERO_CHANGE_STREAMER_URIoption and recommend it as the standard routing mechanism from theview-syncertoreplication-manager.Auto-discovery via
ZERO_CHANGE_STREAMER_MODEis still supported but no longer the recommended configuration. An explicit routing component, while requiring additional setup on the developer's part, works for a wider range of production environments.User report: