chore: cleanup subcommand.rb #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@g-arjones I did this specifically to fix freezes I started having on k8s ... I'm hopeful it might help with the Ruby 3.0 freezes in CI. My objective is to get this to pass and then work on the autoproj PR to get it to pass 100% as well. |
- split the code in smaller methods - rename the file into subprocess.rb since the class is called Subprocess
doudou
force-pushed
the
cleanup_subcommand
branch
from
567ab27 to
129e4ad
Compare
Contributor
|
@doudou Thanks for taking the time. I will have a look later today.
The test matrix addition will conflict with the other branch, but I guess that's fine. I will rebase later |
Contributor
|
This looks so much better. Thanks! |
g-arjones
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major cleanup of the subprocess implementation, along with a switch from fork/exec to spawn. Works on our CI.