Skip to content

Create strings-fr.xml#153

Merged
rodit merged 9 commits intorodit:masterfrom
jbnitro:master
Jun 2, 2022
Merged

Create strings-fr.xml#153
rodit merged 9 commits intorodit:masterfrom
jbnitro:master

Conversation

@jbnitro
Copy link
Contributor

@jbnitro jbnitro commented May 21, 2022

No description provided.

@rodit
Copy link
Owner

rodit commented May 22, 2022

Thank you very much for the translations - they must be moved to values-fr/strings.xml for successful compilation. I will do this in a couple of days, or you can make another commit and I'll re-run the workflow.

@jbnitro
Copy link
Contributor Author

jbnitro commented May 22, 2022

Hello,

I just made the change.
There are still a few sentences to translate.

Thanks

@rodit
Copy link
Owner

rodit commented May 23, 2022

Hi, thanks again - although the build passes, I have noticed the strings.xml is still in the wrong place - it should be in values-fr/strings.xml not values/strings-fr/strings.xml

The translations won't show in the app unless you move the file to values-fr/strings.xml.

@jbnitro
Copy link
Contributor Author

jbnitro commented May 23, 2022

Hello,

My bad, I just made the change again.

Thanks

@rodit rodit merged commit cccafbd into rodit:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants