Update provider templates to match current base class contracts

[Copilot]

The scaffold templates in docs/examples/provider-template/ had drifted from the current base class APIs, making them incorrect guides for implementing new providers.

TemplateSymbolSearchProvider.cs — breaking mismatch (major)

BaseSymbolSearchProvider no longer exposes SearchAsync for override. Derived classes must implement four abstract template methods; the base handles HTTP, rate limiting, and filtering automatically. Replaced the stale direct SearchAsync overrides with the correct hooks:

protected override string BuildSearchUrl(string query, string? assetType, string? exchange) { ... }
protected override string BuildDetailsUrl(string symbol) { ... }
protected override IEnumerable<SymbolSearchResult> DeserializeSearchResults(string json, string query) { ... }
protected override async Task<SymbolDetails?> DeserializeDetailsAsync(string json, string symbol, CancellationToken ct) { ... }

TemplateHistoricalDataProvider.cs

• Constructor: (httpClient, log) → base(httpClient, log) — ILogger? was missing
• if (Disposed) return [] → ThrowIfDisposed() (base helper)
• Inline ArgumentException → ValidateSymbol(symbol) (base helper)
• Added IsAvailableAsync override with credential guard and structured exception logging
• Added [DataSource] + [ImplementsAdr("ADR-005", …)] attributes (were missing)

TemplateMarketDataClient.cs

• Added ILogger? logger optional constructor parameter forwarded to WebSocketProviderBase

README.md

• Updated architecture rules to accurately describe each provider type's required method contract

[github-actions]

🔍 Copilot Code Review — Six-Lens Analysis

⚠️ REQUEST CHANGES — 1 warning(s) and 0 info item(s) should be addressed.

📋 Summary

Metric	Value
Files reviewed	3
🔴 Critical	0
🟡 Warning	1
🔵 Info	0
Build errors	5
Tests passed	0 / 0

📁 Changed files (3)

• docs/examples/provider-template/TemplateHistoricalDataProvider.cs
• docs/examples/provider-template/TemplateMarketDataClient.cs
• docs/examples/provider-template/TemplateSymbolSearchProvider.cs

---

🛡️ Error Handling & Resilience

• [E-WARNING] docs/examples/provider-template/TemplateHistoricalDataProvider.cs: Bare catch (Exception) — use specific types from Core/Exceptions/ (e.g. DataProviderException, StorageException).

---

ℹ️ About this review

This review applies the six-lens framework from code-review-agent.md:

1. 🏗️ MVVM Architecture — thin code-behind, BindableBase, dependency rules
2. ⚡ Real-Time Performance — blocking calls, hot-path allocations, channel policies, ADR-014 JSON
3. 🛡️ Error Handling & Resilience — exception hierarchy, provider reconnection, shutdown paths
4. 🧪 Test Quality — naming convention, async patterns, no sleep/delay
5. 🔌 Provider Compliance — interface completeness, rate limiting, [ImplementsAdr] attributes
6. 📐 Conventions — structured logging, IHttpClientFactory, sealed classes, ADRs

Severity scale: 🔴 CRITICAL (must fix before merge) · 🟡 WARNING (should address) · 🔵 INFO (minor)

[github-actions]

Six-Lens Code Review — 0 critical issue(s) detected. See the detailed comment above for all findings.

[github-actions]

Six-Lens Code Review — 0 critical issue(s) detected. See the detailed comment above for all findings.

[github-actions]

📚 Documentation Automation Summary

Metric	Value
Any changes detected	true
Generated docs changed	true
Changed files	docs/generated/adr-index.md,docs/generated/documentation-coverage.md,docs/generated/project-context.md,docs/generated/repository-structure.md,docs/generated/workflows-overview.md,docs/status/health-dashboard.md
Total TODOs	N/A
Untracked TODOs	N/A
DocFX build	failure
Pages deploy	skipped

This comment is updated automatically by the Documentation Automation workflow.

[github-actions]

Six-Lens Code Review — 0 critical issue(s) detected. See the detailed comment above for all findings.