Skip to content

24 add declaration in tsconfig.json #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roebi merged 5 commits into from
Sep 20, 2023
Merged

24 add declaration in tsconfig.json #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4686ca2
compile with declare
roebi Sep 20, 2023
f6aa1a3
test and prettier
roebi Sep 20, 2023
afe9cdc
String -> string
roebi Sep 20, 2023
8d118b3
String -> string
roebi Sep 20, 2023
e783de7
String -> string
roebi Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export async function getGithubTopicsFromGithub() {
const infoLog = true;
const isProd = true;

const githubTopics = getGithubTopics(loginName, projectName, infoLog, isProd) as Promise<String[]>;
const githubTopics = getGithubTopics(loginName, projectName, infoLog, isProd) as Promise<string[]>;

const realGithubTopics = await githubTopics;
console.group("realGithubTopics");
Expand Down
2 changes: 2 additions & 0 deletions consts.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export declare const GITHUB_API_BASE_URL = "https://api.github.com/";
export declare const GITHUB_HTML_BASE_URL = "https://github.com/";
2 changes: 1 addition & 1 deletion coverage/consts.js.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ <h1><a href="index.html">All files</a> consts.js</h1>
<div class="footer quiet pad2 space-top1 center small">
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at 2023-09-19T23:40:19.793Z
at 2023-09-20T10:23:53.845Z
</div>
<script src="prettify.js"></script>
<script>
Expand Down
12 changes: 6 additions & 6 deletions coverage/githubApiGet.js.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,11 +235,11 @@ <h1><a href="index.html">All files</a> githubApiGet.js</h1>
* @remarks
* This method is part of the {@link githubApi | github-api}.
*
* @param {String} loginName - The github login name
* @param {String} projectName - The github project name
* @param {string} loginName - The github login name
* @param {string} projectName - The github project name
* @param {boolean} infoLog - true Logs group and info into the console
* @param {boolean} isProd - true Calls fetch to github api, false returns mock data with same structure
* @returns {Promise&lt;String[]&gt;} The github topics of a project
* @returns {Promise&lt;string[]&gt;} The github topics of a project
*/
export async function getGithubTopics(loginName, projectName, infoLog, isProd) {
if (infoLog) {
Expand Down Expand Up @@ -269,8 +269,8 @@ <h1><a href="index.html">All files</a> githubApiGet.js</h1>
* @remarks
* This method is part of the {@link githubApi | github-api}.
*
* @param {String} loginName - The github login name
* @param {String} projectName - The github project name
* @param {string} loginName - The github login name
* @param {string} projectName - The github project name
* @param {boolean} infoLog - true Logs group and info into the console
* @param {boolean} isProd - true Calls fetch to github api, false returns mock data with same structure
* @returns {Promise&lt;any&gt;} The github the project object / json of a project
Expand Down Expand Up @@ -317,7 +317,7 @@ <h1><a href="index.html">All files</a> githubApiGet.js</h1>
<div class="footer quiet pad2 space-top1 center small">
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at 2023-09-19T23:40:19.793Z
at 2023-09-20T10:23:53.845Z
</div>
<script src="prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ <h1>All files</h1>
<div class="footer quiet pad2 space-top1 center small">
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at 2023-09-19T23:40:19.793Z
at 2023-09-20T10:23:53.845Z
</div>
<script src="prettify.js"></script>
<script>
Expand Down
Loading