chore: viral gist callout + crop banner whitespace#142
Merged
Conversation
- README: new sub-line under the tagline crediting the design doc gist at 669 stars / 91 forks, with a link. The gist extends Karpathy's LLM Wiki pattern with confidence scoring, lifecycle, knowledge graphs, and hybrid search — it's the spec agentmemory implements, so readers get context on what they're looking at. - assets/banner.png: cropped from 930x512 to 930x332 (removed ~70px dead space from the top and ~110px from the bottom). The wordmark, tagline, orange underline, and top of the neural network graphic are all intact. Aspect ratio is now ~2.8:1 which renders better in the GitHub repo header.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTwo centered elements were added near the top of README.md: a badge/link to the design-doc gist showing star/fork counts, and a centered subtitle describing that the gist extends Karpathy’s LLM Wiki pattern with confidence scoring, lifecycle, knowledge graphs, and hybrid search (agentmemory implementation). Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
README.md (1)
11-11: Avoid hardcoded star/fork counts in README copy.The
669 stars / 91 forksvalue will become stale quickly. Prefer timeless wording (or a dynamic badge) to avoid trust drift.Suggested copy tweak
- <sub>The design doc behind agentmemory went viral: <a href="https://gist.github.com/rohitg00/2067ab416f7bbe447c1977edaaa681e2"><b>669 stars / 91 forks</b> on the gist</a> extending Karpathy's LLM Wiki pattern with confidence scoring, lifecycle, knowledge graphs, and hybrid search.</sub> + <sub>The design doc behind agentmemory: <a href="https://gist.github.com/rohitg00/2067ab416f7bbe447c1977edaaa681e2"><b>popular gist</b></a> extending Karpathy's LLM Wiki pattern with confidence scoring, lifecycle, knowledge graphs, and hybrid search.</sub>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` at line 11, Replace the hardcoded "669 stars / 91 forks" copy in the README line containing "The design doc behind agentmemory ..." and its anchor link with a timeless phrasing or a dynamic badge; locate the exact string "669 stars / 91 forks" and either remove the numeric counts (e.g., "popular gist" or "view the gist") or replace them with a badge/embed that reads live counts, ensuring the anchor link remains intact and the sentence still references the gist URL.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@README.md`:
- Line 11: Replace the hardcoded "669 stars / 91 forks" copy in the README line
containing "The design doc behind agentmemory ..." and its anchor link with a
timeless phrasing or a dynamic badge; locate the exact string "669 stars / 91
forks" and either remove the numeric counts (e.g., "popular gist" or "view the
gist") or replace them with a badge/embed that reads live counts, ensuring the
anchor link remains intact and the sentence still references the gist URL.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7a178ad4-9818-4d3e-bc25-77ea4940f461
⛔ Files ignored due to path filters (1)
assets/banner.pngis excluded by!**/*.png
📒 Files selected for processing (1)
README.md
Previous sub-line was buried as gray <sub>, practically invisible next to the npm/tests/license badges. Replace with a for-the-badge style shield in #FF6B35 (matches the orange underline in the banner) so it catches the eye the moment the page loads. Caption stays as <sub> underneath for people who want the context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two cosmetic README changes.
1. Viral gist callout
Added a one-line sub-credit under the existing tagline linking to the design doc gist: https://gist.github.com/rohitg00/2067ab416f7bbe447c1977edaaa681e2
The gist extends Karpathy's LLM Wiki concept with confidence scoring, lifecycle management, knowledge graphs, and hybrid search — which is essentially the spec agentmemory implements. Giving readers immediate context on the lineage makes the `43 MCP tools / 12 auto hooks / 0 external DBs` stat row land better because they know why those things exist.
Current stats: 669 stars / 91 forks in ~3 days. Crediting it at the top of the README converts some of that gist traffic back into agentmemory repo traffic.
2. Banner crop
Cropped `assets/banner.png` from 930x512 → 930x332 (removed ~70px of dead space from the top and ~110px from the bottom). Visual confirmation: the `agentmemory` wordmark, the "Persistent memory for AI coding agents" tagline, the orange underline, and the top portion of the neural-network graphic are all fully intact. New aspect ratio is ~2.8:1 which renders as a proper cinematic header on the GitHub repo page instead of the current letterbox with two fat black bars.
The existing `<img width="720">` attribute still works — display width is unchanged, the image just no longer wastes vertical space.
Test plan
No code changed. No version bump.
Summary by CodeRabbit