Fix Hermes availability check for agentmemory health endpoint#231
Fix Hermes availability check for agentmemory health endpoint#231hansonkim wants to merge 1 commit into
Conversation
|
@hansonkim is attempting to deploy a commit to the rohitg00's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR refines the Hermes AgentMemoryProvider's availability detection by replacing a generic root-level connectivity check with a dedicated health endpoint probe. The is_available() method now calls GET /agentmemory/health and validates that the response JSON contains a status field with value "healthy" or "ok". ChangesHealth Endpoint Check
Possibly Related PRs
Poem
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing as superseded by #230, which already updates the Hermes availability probe to call /agentmemory/health instead of /. I also verified the same fix locally with Hermes reporting agentmemory as available. |
Summary
/agentmemory/healthinstead of/healthyandokhealth statuses for compatibility with existing health checksWhy
agentmemoryserves its REST API under/agentmemory/*;/can return 404 even while the server is healthy. This makes Hermes report the provider as unavailable despite the documented health endpoint working.Verification
python3 -m py_compile integrations/hermes/__init__.pynpm run buildnpm test(initial run failed because a local agentmemory server forced standalone MCP tests into proxy mode; after stopping the local server, all 75 test files / 838 tests passed)Summary by CodeRabbit