Skip to content

Fix Hermes availability check for agentmemory health endpoint#231

Closed
hansonkim wants to merge 1 commit into
rohitg00:mainfrom
hansonkim:fix/hermes-agentmemory-health-check
Closed

Fix Hermes availability check for agentmemory health endpoint#231
hansonkim wants to merge 1 commit into
rohitg00:mainfrom
hansonkim:fix/hermes-agentmemory-health-check

Conversation

@hansonkim
Copy link
Copy Markdown

@hansonkim hansonkim commented May 7, 2026

Summary

  • Update the Hermes integration availability probe to call /agentmemory/health instead of /
  • Accept both healthy and ok health statuses for compatibility with existing health checks

Why

agentmemory serves its REST API under /agentmemory/*; / can return 404 even while the server is healthy. This makes Hermes report the provider as unavailable despite the documented health endpoint working.

Verification

  • python3 -m py_compile integrations/hermes/__init__.py
  • npm run build
  • npm test (initial run failed because a local agentmemory server forced standalone MCP tests into proxy mode; after stopping the local server, all 75 test files / 838 tests passed)

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced Agentmemory service availability detection to more accurately and reliably determine when the service is operational and ready for user requests.
    • Improved system stability and initialization by strengthening how critical service dependencies are verified, ensuring consistent and proper operation of all downstream features that depend on the Agentmemory service.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2026

@hansonkim is attempting to deploy a commit to the rohitg00's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: eef0205c-0ad9-4518-9826-570f23244823

📥 Commits

Reviewing files that changed from the base of the PR and between 94fc119 and 80d5f6f.

📒 Files selected for processing (1)
  • integrations/hermes/__init__.py

📝 Walkthrough

Walkthrough

The PR refines the Hermes AgentMemoryProvider's availability detection by replacing a generic root-level connectivity check with a dedicated health endpoint probe. The is_available() method now calls GET /agentmemory/health and validates that the response JSON contains a status field with value "healthy" or "ok".

Changes

Health Endpoint Check

Layer / File(s) Summary
Health Endpoint Check
integrations/hermes/__init__.py
AgentMemoryProvider.is_available() now calls GET /agentmemory/health and checks response status field for "healthy" or "ok", replacing prior root GET connectivity check.

Possibly Related PRs

Poem

🐰 A health check hops into the light,
From root to endpoint, now done right,
Healthy and ok, the status sings,
This little change makes such good things!

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix Hermes availability check for agentmemory health endpoint' directly and accurately describes the main change: updating the availability check to use a dedicated health endpoint instead of the base URL.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hansonkim
Copy link
Copy Markdown
Author

Closing as superseded by #230, which already updates the Hermes availability probe to call /agentmemory/health instead of /. I also verified the same fix locally with Hermes reporting agentmemory as available.

@hansonkim hansonkim closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant