fix(hooks): quote plugin script paths

[honor2030]

Summary

• Quote AgentMemory plugin script paths in Claude and Codex hook command templates.
• Add a regression check that hook commands still reference the expected bridge script while remaining safe for plugin roots containing spaces.

Test Plan

• RED: npm test -- test/codex-plugin.test.ts failed before the implementation when the new quoted-path assertion expected shell-safe script paths.
• GREEN: npm test -- test/codex-plugin.test.ts test/context-injection.test.ts → 12 tests passed.
• GREEN: npm run build
• GREEN: git diff --check

Closes #477

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Fixed plugin hooks to correctly handle installation paths containing spaces. Hook commands now properly wrap path variables in quotes to ensure reliable execution regardless of installation directory name.

[vercel]

@honor2030 is attempting to deploy a commit to the rohitg00's projects Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5171b787-2540-4be4-960e-c474dffd1698

📥 Commits

Reviewing files that changed from the base of the PR and between 9061da5 and ee3f166.

📒 Files selected for processing (3)

• plugin/hooks/hooks.codex.json
• plugin/hooks/hooks.json
• test/codex-plugin.test.ts

---

📝 Walkthrough

Walkthrough

This PR fixes hook command failures on Windows when plugin root paths contain spaces by adding double quotes around the ${CLAUDE_PLUGIN_ROOT} variable in all hook command strings across both hook manifests, along with test validation to enforce and maintain the quoted format.

Changes

Hook Command Path Quoting

Layer / File(s)	Summary
Hook manifest command path quoting plugin/hooks/hooks.codex.json, plugin/hooks/hooks.json	All hook command strings now wrap ${CLAUDE_PLUGIN_ROOT}/scripts/*.mjs in double quotes when passed to node, preventing shell path splitting on Windows when usernames contain spaces. Changes applied to SessionStart, UserPromptSubmit, PreToolUse, PostToolUse, PostToolUseFailure, PreCompact, SubagentStart, SubagentStop, Notification, TaskCompleted, Stop, and SessionEnd hooks.
Hook command validation tests test/codex-plugin.test.ts	Added HookHandler and HookEntry types with a hookCommands() helper that loads and validates all hook command strings match the quoted node "${CLAUDE_PLUGIN_ROOT}/scripts/<name>.mjs" format. Existing path extraction test regex refined to correctly parse the quoted format without whitespace leakage.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• rohitg00/agentmemory#311: Both PRs touch the Codex hook manifest and its command-string parsing/validation—main PR updates quoted ${CLAUDE_PLUGIN_ROOT}/scripts/*.mjs commands in plugin/hooks/hooks.codex.json (and adjusts test/codex-plugin.test.ts to match), which directly builds on the Codex plugin/marketplace + hook definitions shipped in PR #311.

Poem

🐰 A path with spaces once broke with a creak,
On Windows machines where quotes we did seek,
Now "${CLAUDE_PLUGIN_ROOT}" keeps the path whole,
No more split-on-spaces—we've fixed this bug's role! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(hooks): quote plugin script paths' accurately summarizes the main change—adding quotes around plugin script paths in hook configurations to fix path handling with spaces.
Linked Issues check	✅ Passed	The pull request fulfills all coding requirements from issue #477: quotes are added to all 11 affected node commands in hooks.json, hooks.codex.json is updated consistently, and regression tests verify the fix without breaking existing functionality.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to issue #477: quoting script paths in hooks.json and hooks.codex.json, plus adding tests to prevent regression. No unrelated modifications are present.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rohitg00]

Merged + shipping in next release.

Thanks @honor2030 — closes #477 (hooks crashing on Windows usernames with spaces). The path-quoting fix + the regression test in test/codex-plugin.test.ts both look clean.