Skip to content

fix(boot): make rebuildIndex non-blocking so viewer + later boot steps run #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohitg00 merged 1 commit into from
May 19, 2026
Merged

fix(boot): make rebuildIndex non-blocking so viewer + later boot steps run #500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,16 +412,24 @@ async function main() {
const needsRebuild = bm25Index.size === 0;

if (needsRebuild) {
const indexCount = await rebuildIndex(kv).catch((err) => {
console.warn(`[agentmemory] Failed to rebuild search index:`, err);
return 0;
});
if (indexCount > 0) {
bootLog(
`Search index rebuilt: ${indexCount} entries`,
);
indexPersistence.scheduleSave();
}
// Fire-and-forget. rebuildIndex iterates every observation across
// every session and AWAITS an embedding-provider call per record.
// On a large corpus + rate-limited embedding endpoint that can
// take HOURS; awaiting it here blocks every subsequent boot step
// (including startViewerServer below, leaving the viewer port
// unbound for the duration). The index lazily fills in over time
// and search degrades gracefully — partial coverage > no viewer
// for hours. Errors still surface via the inner .catch.
void rebuildIndex(kv)
.then((indexCount) => {
if (indexCount > 0) {
bootLog(`Search index rebuilt: ${indexCount} entries`);
indexPersistence.scheduleSave();
}
})
.catch((err) => {
console.warn(`[agentmemory] Failed to rebuild search index:`, err);
});
} else {
// Backfill memories into BM25 for users upgrading from <0.9.5: prior
// versions of mem::remember never indexed memories, so the persisted
Expand Down