Fix to address issue 84; support for spaces in file paths requiring quoting #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jonasbn
commented
May 3, 2022
jonasbn
commented
- This is first shot at a fix of the issue reported in Bump python from 3.10.3-slim-bullseye to 3.10.4-slim-bullseye #86. I believe file paths without space has been working as a conincidence since the splitting has not been working at all, but treating the list of file names as a single string also worked.
- amend!
- Bumped version in examples for the upcoming bug fix release
- Updated the documentation to support the bug fix addressing issue Paths with spaces in source_files parameter does not work #84
- Minor correction to Dockerfile, was executing as sh, but was using Bash script
in #86. I believe file paths without space has been working as a conincidence since the splitting has not been working at all, but treating the list of file names as a single string also worked. Now it should work for both file paths without spaces and file paths with spaces, which however require uniform quoting using either ' (single quotes) or " (double quotes)
This is first shot at a fix of the issue reported in #84. I believe file paths without space has been working as a conincidence since the splitting has not been working at all, but treating the list of file names as a single string also worked. Now it should work for both file paths without spaces and file paths with spaces, which however require uniform quoting using either ' (single quotes) or " (double quotes)
jonasbn
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.