Merged
Conversation
msandula12
force-pushed
the
mike/upgrade-axios
branch
3 times, most recently
from
f17bfbe to
244a2b0
Compare
msandula12
force-pushed
the
mike/upgrade-axios
branch
from
244a2b0 to
cdc1a00
Compare
waltjones
approved these changes
Apr 7, 2026
msandula12
force-pushed
the
mike/upgrade-axios
branch
3 times, most recently
from
f84e38f to
e03814c
Compare
msandula12
force-pushed
the
mike/upgrade-axios
branch
from
982f217 to
1f87841
Compare
Contributor
Author
|
@claude review |
Contributor
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f87841480
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
msandula12
force-pushed
the
mike/upgrade-axios
branch
from
1f87841 to
563d17d
Compare
msandula12
commented
Apr 8, 2026
| - node: 24 | ||
| npm: ^11 | ||
| - node: latest | ||
| npm: latest |
Contributor
Author
There was a problem hiding this comment.
Copied from Rollbar.js: https://github.com/rollbar/rollbar.js/blob/master/.github/workflows/ci.yml#L17-L29
brianr
approved these changes
Apr 8, 2026
waltjones
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Our Axios is a major version behind, which is giving us two security alerts, and likewise causing security alerts for other repos that use this package, such as Olympus.
Here is the v0.x to v1.x migration guide: https://github.com/axios/axios/blob/v1.x/MIGRATION_GUIDE.md
Type of change
Related issues
Checklists
Development
Code review