Skip to content

Conversation

@p-offtermatt
Copy link
Contributor

The previous way of sorting tags didn't work; this was the result when I tried locally for me:

git tag --sort=taggerdate               
v0.50.0
v0.50.1
v0.50.10
v0.50.2
v0.50.2-alpha.1
v0.50.3
v0.50.4
v0.50.5
v0.50.6
v0.50.7
v0.50.8
v0.50.9

This means make install would install v0.50.9.
Here is the order with the version:refname sorting:

git tag --sort=version:refname          
v0.50.0
v0.50.1
v0.50.2
v0.50.2-alpha.1
v0.50.3
v0.50.4
v0.50.5
v0.50.6
v0.50.7
v0.50.8
v0.50.9
v0.50.10

@p-offtermatt p-offtermatt changed the title Fix version tag sorting in Makefile chore: Fix version tag sorting in Makefile Oct 29, 2024
@reecepbcups reecepbcups merged commit afe5b12 into rollchains:release/v0.50 Oct 30, 2024
@p-offtermatt p-offtermatt deleted the ph/fix-tag-sorting branch October 30, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants