fix: type only packages should be considered when marking module external#755
Closed
kalvenschraut wants to merge 2 commits intorolldown:mainfrom
Closed
fix: type only packages should be considered when marking module external#755kalvenschraut wants to merge 2 commits intorolldown:mainfrom
kalvenschraut wants to merge 2 commits intorolldown:mainfrom
Conversation
…a package is external
✅ Deploy Preview for tsdown ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
2 tasks
Member
|
I cannot push my commit on your branch/repo Could you please enable |
Member
|
I pushed your commits directly 0be7c6d |
Member
|
@kalvenschraut I noticed you are part of the @RTVision organization, so I’ve sent you an invitation to my priority support channel here: https://github.com/sxzz-sponsors/discussions/invitations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As I tried to make the tests show if a type only package like @types/json-schema is prod/peer dependency it should be considered external, but only if the runtime dep wouldn't be inlined due to being a dev dependency.
Linked Issues
#745
Additional context