Skip to content

feat(attw): improve ignoreRules type to autocomplete known values#892

Merged
sxzz merged 1 commit intorolldown:mainfrom
mrlubos:fix/attw-ignore-rules-type
Apr 6, 2026
Merged

feat(attw): improve ignoreRules type to autocomplete known values#892
sxzz merged 1 commit intorolldown:mainfrom
mrlubos:fix/attw-ignore-rules-type

Conversation

@mrlubos
Copy link
Copy Markdown
Contributor

@mrlubos mrlubos commented Apr 6, 2026

  • This PR contains AI-generated code, but I have carefully reviewed it myself. Otherwise, my PR may be closed.

Description

Linked Issues

Closes #891

Additional context

I left the type permissive so it allows any string as it did before, this merely improves the autocompletion. Typos will still pass as valid options, let me know if I should make the type strict by removing the string & {} part.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 6, 2026

Deploy Preview for tsdown-main ready!

Name Link
🔨 Latest commit 91a9e6e
🔍 Latest deploy log https://app.netlify.com/projects/tsdown-main/deploys/69d2fe877464150007858576
😎 Deploy Preview https://deploy-preview-892--tsdown-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 6, 2026

Open in StackBlitz

tsdown

pnpm add https://pkg.pr.new/tsdown@892 -D
npm i https://pkg.pr.new/tsdown@892 -D
yarn add https://pkg.pr.new/tsdown@892.tgz -D

create-tsdown

pnpm add https://pkg.pr.new/create-tsdown@892 -D
npm i https://pkg.pr.new/create-tsdown@892 -D
yarn add https://pkg.pr.new/create-tsdown@892.tgz -D

@tsdown/css

pnpm add https://pkg.pr.new/@tsdown/css@892 -D
npm i https://pkg.pr.new/@tsdown/css@892 -D
yarn add https://pkg.pr.new/@tsdown/css@892.tgz -D

@tsdown/exe

pnpm add https://pkg.pr.new/@tsdown/exe@892 -D
npm i https://pkg.pr.new/@tsdown/exe@892 -D
yarn add https://pkg.pr.new/@tsdown/exe@892.tgz -D

tsdown-migrate

pnpm add https://pkg.pr.new/tsdown-migrate@892 -D
npm i https://pkg.pr.new/tsdown-migrate@892 -D
yarn add https://pkg.pr.new/tsdown-migrate@892.tgz -D

commit: 91a9e6e

@sxzz sxzz changed the title feat(attw): improve ignoreRules type to autocomplete known values feat(attw): improve ignoreRules type to autocomplete known values Apr 6, 2026
@sxzz sxzz merged commit c8f5c71 into rolldown:main Apr 6, 2026
14 checks passed
@mrlubos mrlubos deleted the fix/attw-ignore-rules-type branch April 6, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

attw: improve ignoreRules types

2 participants