Skip to content

fix(pkg): fix duplicate configuration warning logic #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sxzz merged 2 commits into from
May 3, 2026
+3 −2
Merged

fix(pkg): fix duplicate configuration warning logic #935

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebb82a6
fix: fix duplicate configuration warning logic by consolidating redun…
ho991217 May 3, 2026
8871403
refactor
sxzz May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/features/pkg/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,9 @@ export async function bundleDone(
const publintConfigs = dedupeConfigs(configs, 'publint')
const attwConfigs = dedupeConfigs(configs, 'attw')

if (publintConfigs.length > 1 || attwConfigs.length > 1) {
publintConfigs[1].logger.warn(
const duplicate = publintConfigs[1] || attwConfigs[1]
if (duplicate) {
duplicate.logger.warn(
`Multiple publint or attw configurations found for package at ${pkg.packageJsonPath}. Consider merging them for better consistency and performance.`,
)
}
Expand Down
Loading