[node-resolve] customResolveOptions.filterPackage alternative wanted

[bbmarkus]

• Rollup Plugin Name: node-resolve
• Rollup Plugin Version: 11.x+

Expected Behavior / Situation

Need an alternative for customResolveOptions.filterPackage, otherwise we will be forced to indefinitely stick with version 10,

Actual Behavior / Situation

[!] Error: node-resolve: customResolveOptions.packageFilter is no longer an option. If you need this, please open an issue

Modification Proposal

Please give me a way to use e.g. an esm module version that some packages include but do not reference through their package json in any fields with node-resolve. Vue would be an example of such a package.

We'd like to override their pkg.main with either "vue.esm-browser.js" or "vue.esm-browser.prod.js", as appropriate, like we have been able to do previously (before #656).

[shellscape]

@tjenkinson perhaps you can touch on this one

[tjenkinson]

Hi @bbmarkus.

We removed passing options directly to node-resolve to remove the coupling of our api to theirs, but also because doing something like overriding the filter meant that our internal one wouldn't run, and it didn't look like we were handling this case properly as we rely on some side effects from our internal filter. Also sometimes we end up running the node-resolve plugin multiple times which could result in your filter being called multiple times, which doesn't really make sense.

I think we can add a top level option back though to achieve what you need. Do you need it to be a callback and get the entire package json or would an object of package name => overridden entry point be enough? Also need to check how this works with packages that have the newer exports field.

[bbmarkus]

@tjenkinson For our use case an object mapping package names to entry points would be sufficient yes.

[tjenkinson]

@bbmarkus cool I think we could add that, although I'm also wondering if this really needs to be part of the node-resolve plugin at all (especially when it's branching away from the node resolve algorithm).

I think you could handle it with a separate plugin like this, before the node-resolve one

{
  name: 'handle-vue-default-import',
  resolveId (source) {
    if (source !== 'vue') return null;
    return path.resolve(path.dirname(require.resolve('vue')), 'vue.esm.js');
  }
}

(untested)

[tjenkinson]

Please let us know if that doesn’t work for you

[stale]

Hey folks. This issue hasn't received any traction for 60 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it. ⓘ