fix(pluginutils): Move @types/estree to dependencies (fixes #1315)#1320
Merged
lukastaegert merged 1 commit intorollup:masterfrom Oct 13, 2022
meyfa:fix/pluginutils-estree
Merged
fix(pluginutils): Move @types/estree to dependencies (fixes #1315)#1320lukastaegert merged 1 commit intorollup:masterfrom meyfa:fix/pluginutils-estree
@types/estree to dependencies (fixes #1315)#1320lukastaegert merged 1 commit intorollup:masterfrom
meyfa:fix/pluginutils-estree
Conversation
estree types are required for downstream packages, since pluginutils/types/index.d.ts makes use of them.
lukastaegert
approved these changes
Oct 13, 2022
9 tasks
lukastaegert
added a commit
that referenced
this pull request
Oct 20, 2022
* fix: Update dependency `@rollup/pluginutils` to ^5.0.1 pluginutils version 4 has a missing production dependency on `@types/estree`, which manifested itself in issue #1315. pluginutils v5.0.1 is now released that fixes this problem (via #1320). This patch updates all plugins that depend on pluginutils to use the fixed version. * fix(babel): Revert pluginutils update * fix(repo): Update remaining Rollup dependencies Co-authored-by: Lukas Taegert-Atkinson <lukas.taegert-atkinson@tngtech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
@rollup/pluginutilsThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers: #1315
Description
estree types are required for downstream packages, since pluginutils/types/index.d.ts makes use of them.
They were previously already part of
dependencies(vs.devDependencies, where they currently are) but were accidentally moved in #616. This breaks TypeScript projects on the newest versions of@rollup/plugin-typescript, for example. See #1315 for more info and a reproduction.