fix(node-resolve): resolve hash in path

[chengcyber]

Rollup Plugin Name: @rollup/plugin-node-resolve

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

This PR is fixing #587

import test from 'test#foo'

treats as hash usage

import test from 'test/#/foo'

treats hash as part of package path

[LarsDenBakker]

This creates a bit of a special case, for instance it would not fix it for test/#foo/bar but I think at least it solves the immediate problem people are having with this. So 👍 from me

[lukastaegert]

I agree this is definitely an improvement and could be released as a partial bug fix.

But looking for a long term fix, why are we stripping BOTH # and ?? Because the core of the problem is that while ? is not a valid character in file names anyway and treating it as a suffix should be safe, # is not. So why are we not fixing it by removing the special handling of # ?

I think it would still solve the original issue #486 in so far as it leaves a way to pass on information, just not via hashes. Thoughts @LarsDenBakker?

[LarsDenBakker]

I agree, ? Is the primary use case so we could leave out hashes.

[lukastaegert]

@chengcyber Would you be willing to modify this PR to remove the special handling for hashes altogether? Of course this would make this a breaking change, but I think this should be worth it in the long run.

[chengcyber]

@lukastaegert, I remove the special handling for hashes in the latest commit, please kindly take another look.

[lukastaegert]

Thanks, can be merged