Skip to content

Clarify docstring#597

Merged
NotWoods merged 1 commit intorollup:masterfrom
verygoodsoftwarenotvirus:documentation-fix
Oct 6, 2020
Merged

Clarify docstring#597
NotWoods merged 1 commit intorollup:masterfrom
verygoodsoftwarenotvirus:documentation-fix

Conversation

@verygoodsoftwarenotvirus
Copy link
Contributor

Rollup Plugin Name: {typescript}

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

I noticed while trying to debug an error that the docstring for the exclude field was (erroneously) the same as the include field. That's all.

@shellscape shellscape requested a review from NotWoods October 5, 2020 20:33
@NotWoods NotWoods merged commit 41d6fd3 into rollup:master Oct 6, 2020
@shellscape
Copy link
Collaborator

@NotWoods please make sure you're using conventional commit for PR merges. just published a release and noticed that was missed in the change log.

@NotWoods
Copy link
Member

Sorry, I've been trying to check them but this one slipped through

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants